Skip to content

Commit 32c7abb

Browse files
committedJul 18, 2023
fix: intermediary fix for #1771
1 parent 16abf31 commit 32c7abb

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed
 

‎test-app/runtime/src/main/cpp/MetadataNode.cpp

+3
Original file line numberDiff line numberDiff line change
@@ -945,6 +945,9 @@ void MetadataNode::SetInnerTypes(Isolate* isolate, Local<Function>& ctorFunction
945945
}
946946
auto innerTypeCtorFunc = Local<Function>::New(isolate, *GetOrCreateInternal(curChild)->GetPersistentConstructorFunction(isolate));
947947
auto innerTypeName = ArgConverter::ConvertToV8String(isolate, curChild->name);
948+
// TODO: remove this once we solve https://github.com/NativeScript/android/pull/1771
949+
// this avoids a crash, but the companion object is still unaccessible
950+
TryCatch tc(isolate);
948951
ctorFunction->Set(context, innerTypeName, innerTypeCtorFunc);
949952
}
950953
}

0 commit comments

Comments
 (0)