Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to easily disable skills-client #209

Open
rmmayo opened this issue Mar 30, 2023 · 1 comment
Open

Add the ability to easily disable skills-client #209

rmmayo opened this issue Mar 30, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@rmmayo
Copy link
Collaborator

rmmayo commented Mar 30, 2023

Add new optional enabled parameter to the configure method:

 this.SkillsClient.SkillsConfiguration.configure({
           serviceUrl: 'http://localhost:8080',
           projectId: 'your-project-id',
           authenticator: '<auth>',
           enabled: false
        });

when disabled the skills-client library should remain dormant, and not attempt auth, network communication, skill reporting, etc.

Please Note: enabled will default to true

@rmmayo rmmayo added the enhancement New feature or request label Mar 30, 2023
@sudo-may sudo-may self-assigned this Oct 8, 2024
sudo-may added a commit that referenced this issue Oct 8, 2024
@sudo-may
Copy link
Collaborator

sudo-may commented Oct 9, 2024

PR: #254

@sudo-may sudo-may added this to the 3.6.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants