-
Notifications
You must be signed in to change notification settings - Fork 19
Project creation form #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alneberg
wants to merge
80
commits into
NationalGenomicsInfrastructure:master
Choose a base branch
from
alneberg:project_creation_form
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Project creation form #975
alneberg
wants to merge
80
commits into
NationalGenomicsInfrastructure:master
from
alneberg:project_creation_form
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidation is not triggered, dont't know why
Add suggestions on account name, autofill of project name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the functionality to create a project from a user interface in Genomics Status. The project will be saved in LIMS using the API. Since the projects are always editable in LIMS, potential issues with this feature can be adjusted there.
To create the project, the project coordinator fills out a form (defined as a json document) and presses a submit button. The reason for this feature is that he user interface in LIMS is quite bad, with only a very small section of the form viewable at once. The LIMS UI can also not deprecate some UDF values, so the list of possible values to select can grow very large. The genstat UI will use the full page to load the form, be able to deprecate values and in addition can assist with auto-filling in values and fetching suggestions. Some fields in the form will also only be viewable if some conditions are met.
In addition, a fairly complex feature to edit these forms is introduced. This will update the form json document in statusdb.