Inconsistencies between direct key access and `.get` usage.

[NandaScott]

There are some inconsistencies between how properties access scryfallData, where some of them use direct key access (scryfallData['value']) and using a getter (scryfallData.get('value'). It should really be one or the other, and we should consider the implications of each method.

[mazz3rr]

Also, when working with sets there's an inconsistency of getting either scrython.sets.ByCode or plain scrython.sets.Object. I mean, if one follows:

# Get all sets
all_sets = scrython.sets.All()

for set_obj in all_sets.data:
    print(f"{set_obj.name} ({set_obj.code}) - {set_obj.card_count} cards")

# Get specific set
set_obj = scrython.sets.ByCode(code='znr')
print(f"{set_obj.name} released on {set_obj.released_at}")
print(f"Set type: {set_obj.set_type}")

then, one obtains the latter in "Get all sets" case and the former in "Get specific set".

Maybe it's not inconsistency per se, but, as a user, I don't like being coerced into finding and using the private _scryfall_data attribute on scrython.sets.Object because they come unequipped with to_dict() that scrython.sets.ByCode objects posses.

Maybe there's some conversion available of plain Object into ByCode (or some other specialized class) that I miss?

[NandaScott]

@mazz3rr That's a fair point, and not something I considered. I think there were some questionable choices made on my part when I rewrote this project. I think the simplest fix on my end is to decouple those helper methods from ScrythonRequestHandler and put them in a mixin that Object can inherit from. This way, all objects should have access to to_dict(), to_json(), etc.

It's not exactly related to the original issue, but I really need to take a closer look at the patterns I'm using in this library. I don't think it'll require a rewrite, but a round of refactoring would help.