Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on failure (after reconnecting) #17

Closed
jeffreyzant opened this issue Jul 26, 2023 · 1 comment
Closed

Retry on failure (after reconnecting) #17

jeffreyzant opened this issue Jul 26, 2023 · 1 comment

Comments

@jeffreyzant
Copy link

Hi there!

Thanks for creating this (much simpler) version of the sentinel driver. We've started to move away from our pull request (monospice/laravel-redis-sentinel-drivers#36) to this package.

One big difference I've seem to find is that this package does not retry the executed command when the master Redis instance goes away (for instance with a rolling update). Might be interesting to implement it, for instance: https://github.com/monospice/laravel-redis-sentinel-drivers/pull/36/files#diff-3bf85f59585710cebd9ae7787d8b7ffb7df273ce8ffe2e72053ef96b4bb81ccaR256.

I'd be willing to put in the time for the pull request if you are open for it!

@Namoshek
Copy link
Owner

I'm currently not working anymore on the project for which this library was built and in the end, we also moved away from redis-sentinel altogether. Although I remember building retry logic around the normal Redis driver... so this is not something new to me.

However, I'm of course open to suggestions on how to implement this. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants