Skip to content

fix(ci): align vibecoder workflows with npm and current trivy action #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nadav011 merged 1 commit into from
Mar 29, 2026
Merged

fix(ci): align vibecoder workflows with npm and current trivy action #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,21 +17,14 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Add Node.js (fnm) to PATH
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH

- name: Enable pnpm via corepack
run: corepack enable pnpm


- name: Install dependencies
run: pnpm install --frozen-lockfile
run: npm ci

Comment on lines 19 to 22

Copilot AI Mar 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint-typecheck runs npm ci/npm run ... on a self-hosted runner but the workflow no longer ensures Node.js is available (no actions/setup-node and no fnm PATH injection). Other workflows in this repo still add the fnm-managed Node v24.14.0 to $GITHUB_PATH, so this job may fail if Node isn’t already on PATH or if a different Node version is picked up. Consider adding back a Node setup step (either actions/setup-node pinned to the expected version or the same fnm PATH export used elsewhere) before npm ci.

Copilot uses AI. Check for mistakes.
- name: Lint
run: pnpm run lint
run: npm run lint

- name: Typecheck
run: pnpm run typecheck
run: npm run typecheck

semgrep:
name: Semgrep (SAST)
Expand Down Expand Up @@ -65,7 +58,7 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Trivy scan
uses: aquasecurity/trivy-action@master
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
with:
scan-type: fs
scan-ref: .
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/checkout@v4

- name: Trivy vulnerability scanner
uses: aquasecurity/trivy-action@v0.30.0
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
with:
scan-type: fs
scan-ref: .
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/trivy-autofix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v4

- name: Trivy vulnerability scan
uses: aquasecurity/trivy-action@v0.30.0
uses: aquasecurity/trivy-action@57a97c7e7821a5776cebc9bb87c984fa69cba8f1 # v0.35.0
with:
scan-type: fs
scan-ref: .
Expand Down Expand Up @@ -44,10 +44,6 @@ jobs:
if: steps.check.outputs.count != '0'
run: echo "$HOME/.local/share/fnm/node-versions/v24.14.0/installation/bin" >> $GITHUB_PATH

- name: Enable pnpm via corepack
if: steps.check.outputs.count != '0'
run: corepack enable pnpm

- name: Auto-fix CVEs via npm overrides
if: steps.check.outputs.count != '0'
run: |
Expand All @@ -71,6 +67,10 @@ jobs:
f.write(chr(10))
"

- name: Install dependencies after override patch
if: steps.check.outputs.count != '0'
run: npm install --package-lock-only

- name: Create Pull Request
if: steps.check.outputs.count != '0'
uses: peter-evans/create-pull-request@v7
Expand Down
Loading