Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apprise not using Flickr account restriction #70

Open
killervette42 opened this issue May 19, 2024 · 14 comments
Open

Apprise not using Flickr account restriction #70

killervette42 opened this issue May 19, 2024 · 14 comments
Labels
bug Something isn't working

Comments

@killervette42
Copy link

I set my Flickr api and account. The website pulls images from my Flickr, however the apprise notifications choose any image from Flickr. I would expect it to pick images from my account specified.

@lloydbayley
Copy link

No, It's more simple than that. It uses your details to log in to Flickr and use the API. The images are pulled from Flickr based on the names.

@killervette42
Copy link
Author

Is that just for the apprise section. The webpage works correctly and shows only images from my account which is specified.

@lloydbayley
Copy link

Really? Well actually, I hadn't delved that deep into it. I just accepted that it showed pictures. I have a basic Flickr account with no pictures, so I hadn't noticed! I'll have another look through the code.

@killervette42
Copy link
Author

Yea. On the webpage of my account doesn’t have a picture of a certain bird, no picture shows. But it worked perfectly for the birds I do have pics for.

Just apprise ignores it.

@lloydbayley
Copy link

You're absolutely correct. Notifications don't honour the filter. We can stick it on the to-do list! (Unless @Nachtzuster has already begun)...

@killervette42
Copy link
Author

Great, thanks!

@Nachtzuster Nachtzuster added the bug Something isn't working label May 21, 2024
@Nachtzuster
Copy link
Owner

stick it on the to-do list!

indeed

@killervette42
Copy link
Author

Also, it's ignored when you go to Best Recordings and then pick a species.

@lloydbayley
Copy link

lloydbayley commented Jul 12, 2024

@Nachtzuster Did anyone look into this (I know I forgot) or is it still on 'the list' ? :)

@Nachtzuster
Copy link
Owner

Nachtzuster commented Jul 12, 2024

It is still very much open, unfortunately

@lloydbayley
Copy link

Ok, will try to remember to have a look at this over the weekend!

@lloydbayley
Copy link

lloydbayley commented Jul 16, 2024

Just as a small update, I've had a good look at this and it's a bit yukky....since the notify is in python and the main one is in PHP, it will require some effort. I'm going to have a think about this. I need to re-construct the fetch in python with the email filter.

@Nachtzuster
Copy link
Owner

I see.
Maybe another option would be to expose the php flickr functionality as a (rest?) api, so that the python code can call it.
Only one place with flickr logic would be nice.
Just an idea, I have not looked into how involved that would be

@lloydbayley
Copy link

It certainly makes sense. A bit beyond my skillset at the moment I'm afraid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants