Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping tags.cncf.io/container-device-interface from v0.8.0 to v1.0.0 downgrade go version of nvidia-container-toolkit #995

Open
gabrielmougard opened this issue Mar 14, 2025 · 1 comment

Comments

@gabrielmougard
Copy link

As part of a version bump in our project (https://github.com/canonical/lxd) from tags.cncf.io/container-device-interface v0.8.0 to tags.cncf.io/container-device-interface v1.0.0 , we also had to update our go deps with an updated github.com/NVIDIA/nvidia-container-toolkit that would properly work with this change. I looked a bit and I found this commit that was part of this PR.

I naively did go get github.com/NVIDIA/nvidia-container-toolkit@3df59b955a77edbc2f261533f14e61858ea4687d to receive the updated dependency (our go build works after that) but I found out that the resolved go.mod deps was:

github.com/NVIDIA/nvidia-container-toolkit v1.17.1-0.20250310084538-3df59b955a77

We were previously using v1.17.4 . Why this change appears in 1.17.1-... and not in a newer version like v1.17.5 ?

@gabrielmougard gabrielmougard changed the title bumping tags.cncf.io/container-device-interface from v0.8.0 to v1.0.0 commit get bumping tags.cncf.io/container-device-interface from v0.8.0 to v1.0.0 downgrade go version of nvidia-container-toolkit Mar 14, 2025
@elezar
Copy link
Member

elezar commented Mar 17, 2025

@gabrielmougard I believe this is a sideeffect of how go generates pseudo versions. The v1.17.1 tag existed on the main branch at the time, and we have since created a release-1.17 branch for subsequent tags.

We did not want to "polute" the v1.17.5 release with the CDI update since it happened late in our release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants