Skip to content

Commit 39a2cba

Browse files
klueskatariq1890
authored andcommitted
WIP: Update vendoring from go-nvlib
This pulls in a temporary change to ensure that the CI created within a GI is always of maximum size. It is a WIP because the change in go-nvlib is not yet finalized, so we can't actually vendor in the solution yet. It works by reversing the loop that walks through CIs to ensure that we visit up any "newer" CI profiles before visiting older ones. The assumption being that newer ones may provide a CI definition that has a larger memory slice count with the same compute slice count. Unfortunately, we don't have a way to distinguish this in the canonical naming convention, so the same names refers to both MIG devices -- hence the bug. We need a more robust / comprehensive solution to this issue, possibly introducing a "custom" naming convention to distibguish the cases. Signed-off-by: Kevin Klues <[email protected]>
1 parent 3d3fca7 commit 39a2cba

File tree

5 files changed

+356
-73
lines changed

5 files changed

+356
-73
lines changed

go.mod

+3-1
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,10 @@ go 1.22.0
44

55
toolchain go1.22.5
66

7+
replace github.com/NVIDIA/go-nvlib => github.com/NVIDIA/go-nvlib v0.7.1-0.20250107124257-ab7bb86cf9d1
8+
79
require (
8-
github.com/NVIDIA/go-nvlib v0.7.0
10+
github.com/NVIDIA/go-nvlib v0.0.0-00010101000000-000000000000
911
github.com/NVIDIA/go-nvml v0.12.4-0
1012
github.com/sirupsen/logrus v1.9.3
1113
github.com/stretchr/testify v1.10.0

go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
github.com/NVIDIA/go-nvlib v0.7.0 h1:Z/J7skMdLbTiHvomKVsGYsttfQMZj5FwNYIFXhZ4i/c=
2-
github.com/NVIDIA/go-nvlib v0.7.0/go.mod h1:9UrsLGx/q1OrENygXjOuM5Ey5KCtiZhbvBlbUIxtGWY=
1+
github.com/NVIDIA/go-nvlib v0.7.1-0.20250107124257-ab7bb86cf9d1 h1:pvWhaPRXgbhuIP+XKrLjz+Y5OHHTWMwH9YCCEC0ppO4=
2+
github.com/NVIDIA/go-nvlib v0.7.1-0.20250107124257-ab7bb86cf9d1/go.mod h1:9UrsLGx/q1OrENygXjOuM5Ey5KCtiZhbvBlbUIxtGWY=
33
github.com/NVIDIA/go-nvml v0.12.4-0 h1:4tkbB3pT1O77JGr0gQ6uD8FrsUPqP1A/EOEm2wI1TUg=
44
github.com/NVIDIA/go-nvml v0.12.4-0/go.mod h1:8Llmj+1Rr+9VGGwZuRer5N/aCjxGuR5nPb/9ebBiIEQ=
55
github.com/cpuguy83/go-md2man/v2 v2.0.5 h1:ZtcqGrnekaHpVLArFSe4HK5DoKx1T0rq2DwVB0alcyc=

vendor/github.com/NVIDIA/go-nvlib/pkg/nvlib/device/device.go

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)