Skip to content

Commit 0d435d8

Browse files
committed
Rename MultiNodeEnvironment to ComputeDomain
Signed-off-by: Kevin Klues <[email protected]>
1 parent 9733823 commit 0d435d8

30 files changed

+746
-743
lines changed

api/nvidia.com/resource/gpu/v1alpha1/api.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ const (
2727
GroupName = "gpu.nvidia.com"
2828
Version = "v1alpha1"
2929

30-
GpuConfigKind = "GpuConfig"
31-
MigDeviceConfigKind = "MigDeviceConfig"
32-
ImexChannelConfigKind = "ImexChannelConfig"
33-
ImexDaemonConfigKind = "ImexDaemonConfig"
34-
MultiNodeEnvironmentKind = "MultiNodeEnvironment"
30+
GpuConfigKind = "GpuConfig"
31+
MigDeviceConfigKind = "MigDeviceConfig"
32+
ImexChannelConfigKind = "ImexChannelConfig"
33+
ImexDaemonConfigKind = "ImexDaemonConfig"
34+
ComputeDomainKind = "ComputeDomain"
3535
)
3636

3737
// Interface defines the set of common APIs for all configs
@@ -59,7 +59,7 @@ func init() {
5959
&MigDeviceConfig{},
6060
&ImexChannelConfig{},
6161
&ImexDaemonConfig{},
62-
&MultiNodeEnvironment{},
62+
&ComputeDomain{},
6363
)
6464
metav1.AddToGroupVersion(scheme, schemeGroupVersion)
6565

api/nvidia.com/resource/gpu/v1alpha1/multinode.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,28 @@ import (
2525
// +k8s:openapi-gen=true
2626
// +kubebuilder:resource:scope=Namespaced
2727

28-
// MultiNodeEnvironment prepares a set of nodes to run a multi-node workload in.
29-
type MultiNodeEnvironment struct {
28+
// ComputeDomain prepares a set of nodes to run a multi-node workload in.
29+
type ComputeDomain struct {
3030
metav1.TypeMeta `json:",inline"`
3131
metav1.ObjectMeta `json:"metadata,omitempty"`
3232

33-
Spec MultiNodeEnvironmentSpec `json:"spec,omitempty"`
33+
Spec ComputeDomainSpec `json:"spec,omitempty"`
3434
}
3535

3636
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
3737

38-
// MultiNodeEnvironmentList provides a list of MultiNodeEnvironments.
39-
type MultiNodeEnvironmentList struct {
38+
// ComputeDomainList provides a list of ComputeDomains.
39+
type ComputeDomainList struct {
4040
metav1.TypeMeta `json:",inline"`
4141
metav1.ListMeta `json:"metadata,omitempty"`
4242

43-
Items []MultiNodeEnvironment `json:"items"`
43+
Items []ComputeDomain `json:"items"`
4444
}
4545

4646
// +kubebuilder:validation:XValidation:rule="(has(self.resourceClaimName) ? !has(self.deviceClassName) : has(self.deviceClassName))",message="Exactly one of 'resourceClaimName' or 'deviceClassName' must be set."
4747

48-
// MultiNodeEnvironmentSpec provides the spec for a MultiNodeEnvironment.
49-
type MultiNodeEnvironmentSpec struct {
48+
// ComputeDomainSpec provides the spec for a ComputeDomain.
49+
type ComputeDomainSpec struct {
5050
NumNodes int `json:"numNodes"`
5151
ResourceClaimName string `json:"resourceClaimName,omitempty"`
5252
DeviceClassName string `json:"deviceClassName,omitempty"`

api/nvidia.com/resource/gpu/v1alpha1/register.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ func Resource(resource string) schema.GroupResource {
4141

4242
func addKnownTypes(scheme *runtime.Scheme) error {
4343
scheme.AddKnownTypes(SchemeGroupVersion,
44-
&MultiNodeEnvironment{},
45-
&MultiNodeEnvironmentList{},
44+
&ComputeDomain{},
45+
&ComputeDomainList{},
4646
)
4747
metav1.AddToGroupVersion(scheme, SchemeGroupVersion)
4848
return nil

api/nvidia.com/resource/gpu/v1alpha1/zz_generated.deepcopy.go

+73-73
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/nvidia-dra-imex-controller/controller.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func NewController(config *Config) *Controller {
5454
}
5555

5656
// Run starts the controller's main loop and manages the lifecycle of its components.
57-
// It initializes the work queue, starts the MultiNodeEnvironment manager, and handles
57+
// It initializes the work queue, starts the ComputeDomain manager, and handles
5858
// graceful shutdown when the context is cancelled.
5959
func (c *Controller) Run(ctx context.Context) error {
6060
workQueue := workqueue.New(workqueue.DefaultControllerRateLimiter())
@@ -66,16 +66,16 @@ func (c *Controller) Run(ctx context.Context) error {
6666
workQueue: workQueue,
6767
}
6868

69-
mneManager := NewMultiNodeEnvironmentManager(managerConfig)
69+
cdManager := NewComputeDomainManager(managerConfig)
7070

71-
if err := mneManager.Start(ctx); err != nil {
72-
return fmt.Errorf("error starting MultiNodeEnvironment manager: %w", err)
71+
if err := cdManager.Start(ctx); err != nil {
72+
return fmt.Errorf("error starting ComputeDomain manager: %w", err)
7373
}
7474

7575
workQueue.Run(ctx)
7676

77-
if err := mneManager.Stop(); err != nil {
78-
return fmt.Errorf("error stopping MultiNodeEnvironment manager: %w", err)
77+
if err := cdManager.Stop(); err != nil {
78+
return fmt.Errorf("error stopping ComputeDomain manager: %w", err)
7979
}
8080

8181
return nil

0 commit comments

Comments
 (0)