Skip to content

Commit 228422c

Browse files
committed
unused aws instace and vpcs cleanup
Signed-off-by: shiva kumar <[email protected]>
1 parent c6bbb06 commit 228422c

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

tests/aws_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"github.com/NVIDIA/holodeck/pkg/jyaml"
3030
"github.com/NVIDIA/holodeck/pkg/provider"
3131
"github.com/NVIDIA/holodeck/pkg/provisioner"
32+
"github.com/NVIDIA/holodeck/tests/common"
3233
)
3334

3435
// Actual test suite
@@ -55,8 +56,8 @@ var _ = Describe("AWS", func() {
5556
Expect(err).ToNot(HaveOccurred())
5657

5758
// Set unique name for the environment
58-
// Set env name
5959
common.setCfgName(&opts.cfg)
60+
opts.cfg.Name = opts.cfg.Name + "-" + common.GenerateUID()
6061
// set cache path
6162
opts.cachePath = LogArtifactDir
6263
// set cache file

tests/common/common.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ func setCfgName(cfg *v1alpha1.Environment) {
4242
if len(sha) > 8 {
4343
sha = sha[:8]
4444
}
45-
// uid is unique for each run
46-
uid := GenerateUID()
45+
// // uid is unique for each run
46+
// uid := GenerateUID()
4747

48-
cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)
48+
// cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)
49+
cfg.Name = fmt.Sprintf("ci%s-%s", attempt, sha)
4950
}

0 commit comments

Comments
 (0)