Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the NVIDIADriver CRD (manager and startupProbe fields) merged with the default? #630

Closed
skirsten opened this issue Dec 10, 2023 · 1 comment

Comments

@skirsten
Copy link

Nowhere does it mention what happens to fields such as manager in the NVIDIADriver CRD if its empty.

In the docs and examples an empty object is provided:

manager: {}

But the "default" NVIDIADriver includes the whole definition for the manager as well as startupProbe:

manager: 
  env:
  - name: ENABLE_GPU_POD_EVICTION
    value: "true"
  - name: ENABLE_AUTO_DRAIN
    value: "false"
  - name: DRAIN_USE_FORCE
    value: "false"
  - name: DRAIN_POD_SELECTOR_LABEL
    value: ""
  - name: DRAIN_TIMEOUT_SECONDS
    value: 0s
  - name: DRAIN_DELETE_EMPTYDIR_DATA
    value: "false"
  image: k8s-driver-manager
  imagePullPolicy: IfNotPresent
  repository: nvcr.io/nvidia/cloud-native
  version: v0.6.5
startupProbe: 
  failureThreshold: 120
  initialDelaySeconds: 60
  periodSeconds: 10
  timeoutSeconds: 60

I really don't want to have this in the CRD and have to update it so I am hoping that if the manager and startupProbe is not provided (or empty) it will default to that. Can somebody confirm or deny this?

@shivamerla
Copy link
Contributor

@skirsten your understanding is correct. Driver manager image is set as an env by default with the operator deployment.

        - name: "DRIVER_MANAGER_IMAGE"
          value: "nvcr.io/nvidia/cloud-native/k8s-driver-manager:v0.6.2"

So, this need not be specified in each NVIDIADriver instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants