Skip to content

Is the NVIDIADriver CRD (manager and startupProbe fields) merged with the default? #630

Closed
@skirsten

Description

@skirsten

Nowhere does it mention what happens to fields such as manager in the NVIDIADriver CRD if its empty.

In the docs and examples an empty object is provided:

manager: {}

But the "default" NVIDIADriver includes the whole definition for the manager as well as startupProbe:

manager: 
  env:
  - name: ENABLE_GPU_POD_EVICTION
    value: "true"
  - name: ENABLE_AUTO_DRAIN
    value: "false"
  - name: DRAIN_USE_FORCE
    value: "false"
  - name: DRAIN_POD_SELECTOR_LABEL
    value: ""
  - name: DRAIN_TIMEOUT_SECONDS
    value: 0s
  - name: DRAIN_DELETE_EMPTYDIR_DATA
    value: "false"
  image: k8s-driver-manager
  imagePullPolicy: IfNotPresent
  repository: nvcr.io/nvidia/cloud-native
  version: v0.6.5
startupProbe: 
  failureThreshold: 120
  initialDelaySeconds: 60
  periodSeconds: 10
  timeoutSeconds: 60

I really don't want to have this in the CRD and have to update it so I am hoping that if the manager and startupProbe is not provided (or empty) it will default to that. Can somebody confirm or deny this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions