From 5bf8472d46fc91731de39f1ebbb887d66566e5e4 Mon Sep 17 00:00:00 2001 From: Larry Chen Date: Wed, 8 Apr 2026 18:50:48 +0800 Subject: [PATCH 1/2] fix: helm-package-push: use dynamic package dir, add multi-chart outputs and cleanup step --- .github/actions/helm-package-push/action.yml | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/.github/actions/helm-package-push/action.yml b/.github/actions/helm-package-push/action.yml index 4f1e7ba..78441f6 100644 --- a/.github/actions/helm-package-push/action.yml +++ b/.github/actions/helm-package-push/action.yml @@ -82,6 +82,9 @@ runs: HELM_CHART_APP_VERSION: ${{ inputs.app-version }} CC_HELM_CHART_PATH: ${{ inputs.chart-path }} run: | + CC_HELM_PACKAGE_DIR="${GITHUB_ACTION}-package" + echo "CC_HELM_PACKAGE_DIR=${CC_HELM_PACKAGE_DIR}" >> "$GITHUB_ENV" + export CC_HELM_PACKAGE_DIR UTILS_PATH="${{ github.action_path }}/../helm-shared/scripts/utils.sh" "$UTILS_PATH" helm_init_package @@ -97,7 +100,6 @@ runs: shell: bash env: CC_HELM_CHART_PATH: ${{ inputs.chart-path }} - CC_HELM_PACKAGE_DIR: "package" CC_HELM_LINT: ${{ inputs.lint }} run: | UTILS_PATH="${{ github.action_path }}/../helm-shared/scripts/utils.sh" @@ -109,7 +111,6 @@ runs: shell: bash if: inputs.ngc-push == 'true' env: - CC_HELM_PACKAGE_DIR: "package" CC_HELM_NGC_KEY: ${{ inputs.ngc-key }} CC_HELM_NGC_PATH: ${{ inputs.ngc-path }} CC_HELM_NGC_REGISTRY: ${{ inputs.ngc-registry }} @@ -137,11 +138,24 @@ runs: id: set_outputs shell: bash run: | - # These variables should be available from Init Package/Push steps echo "chart-name=${CC_HELM_CHART_NAME:-}" >> "$GITHUB_OUTPUT" echo "chart-version=${CC_HELM_CHART_VERSION:-}" >> "$GITHUB_OUTPUT" + + if [[ -n "${CC_HELM_CHART_LIST:-}" && "${CC_HELM_CHART_LIST}" != "[]" ]]; then + echo "chart-names=$(echo "$CC_HELM_CHART_LIST" | jq -c '[.[].name]')" >> "$GITHUB_OUTPUT" + echo "chart-versions=$(echo "$CC_HELM_CHART_LIST" | jq -c '[.[].version]')" >> "$GITHUB_OUTPUT" + fi + + echo "push-results=${CC_HELM_NGC_PUSH_RESULTS:-[]}" >> "$GITHUB_OUTPUT" + if [[ "${CC_HELM_NGC_PUSH_STATUS:-}" == "skipped" ]]; then echo "push-skipped=true" >> "$GITHUB_OUTPUT" else echo "push-skipped=false" >> "$GITHUB_OUTPUT" fi + + - name: Cleanup Package Directory + shell: bash + if: always() + run: | + [[ -n "${CC_HELM_PACKAGE_DIR:-}" ]] && rm -rf "${CC_HELM_PACKAGE_DIR}" From 8058c8f6b1002ecbd453a3b711f530d2f455ba2c Mon Sep 17 00:00:00 2001 From: Larry Chen Date: Thu, 9 Apr 2026 08:58:33 +0800 Subject: [PATCH 2/2] fix: remove unused segment --- .github/actions/helm-package-push/action.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/actions/helm-package-push/action.yml b/.github/actions/helm-package-push/action.yml index 78441f6..0586a90 100644 --- a/.github/actions/helm-package-push/action.yml +++ b/.github/actions/helm-package-push/action.yml @@ -141,13 +141,6 @@ runs: echo "chart-name=${CC_HELM_CHART_NAME:-}" >> "$GITHUB_OUTPUT" echo "chart-version=${CC_HELM_CHART_VERSION:-}" >> "$GITHUB_OUTPUT" - if [[ -n "${CC_HELM_CHART_LIST:-}" && "${CC_HELM_CHART_LIST}" != "[]" ]]; then - echo "chart-names=$(echo "$CC_HELM_CHART_LIST" | jq -c '[.[].name]')" >> "$GITHUB_OUTPUT" - echo "chart-versions=$(echo "$CC_HELM_CHART_LIST" | jq -c '[.[].version]')" >> "$GITHUB_OUTPUT" - fi - - echo "push-results=${CC_HELM_NGC_PUSH_RESULTS:-[]}" >> "$GITHUB_OUTPUT" - if [[ "${CC_HELM_NGC_PUSH_STATUS:-}" == "skipped" ]]; then echo "push-skipped=true" >> "$GITHUB_OUTPUT" else