Exclude SPDX copyright lines from .clang-format#2275
Merged
Conversation
achirkin
added
bug
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
Note, the error was first encountered in #2237 , which now includes the same fix to test it. clang-format.............................................................Failed
- hook id: clang-format
- files were modified by this hook
...
verify-copyright-cuvs....................................................Failed
- hook id: verify-copyright
- exit code: 1
- files were modified by this hook
In file cpp/src/neighbors/detail/cagra/compute_distance.hpp:2:28:
* SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION &
AFFILIATES. All rights
warning: copyright notice does not match canonical notice
In file cpp/src/neighbors/detail/cagra/compute_distance.hpp:2:28:
- * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION &
AFFILIATES. All rights
+ * SPDX-FileCopyrightText: Copyright (c) 2023-2026, NVIDIA CORPORATION &
AFFILIATES. All rights reserved.
note: suggested fix applied |
aamijar
approved these changes
Jun 29, 2026
cjnolet
approved these changes
Jun 29, 2026
KyleFromNVIDIA
approved these changes
Jun 29, 2026
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NVIDIA's full copyright notice may exceed
ColumnLimit: 100and cause clang-format to corrupt the header for multi-year files.This PR excludes the copyright line from clang-format checks to workaround this problem.