Skip to content

Commit fcc5031

Browse files
authored
remove docs references to cuvs-bench-datasets, install a C compiler in pre-commit env (#1736)
## Updates docs RAPIDS used to publish a `rapidsai/cuvs-bench-datasets` container image, essentially `rapidsai/cuvs-bench` with some benchmarking datasets pre-downloaded. `rapidsai/cuvs-bench-datasets` was last published over a year ago (rapidsai/docker#725) and is set to be abandoned. This removes references to it in documentation. ## Installs a C compiler for `pre-commit` Looks like the `cargo-fmt` hook was relying on the C compilers removed from the `rapidsai/ci-conda` images in rapidsai/ci-imgs#353 This fixes that by explicitly declaring that dependency in the conda environment used for `pre-commit` in CI. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) - Bradley Dice (https://github.com/bdice) URL: #1736
1 parent 876fa87 commit fcc5031

3 files changed

Lines changed: 10 additions & 5 deletions

File tree

ci/check_style.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/bin/bash
2-
# SPDX-FileCopyrightText: Copyright (c) 2020-2025, NVIDIA CORPORATION.
2+
# SPDX-FileCopyrightText: Copyright (c) 2020-2026, NVIDIA CORPORATION.
33
# SPDX-License-Identifier: Apache-2.0
44

55
set -euo pipefail
@@ -15,8 +15,11 @@ rapids-dependency-file-generator \
1515
--file-key checks \
1616
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee env.yaml
1717

18+
# temporarily allow unbound variables for conda activation scripts
19+
set +u
1820
rapids-mamba-retry env create --yes -f env.yaml -n checks
1921
conda activate checks
22+
set -u
2023

2124
# get config for cmake-format checks
2225
RAPIDS_BRANCH="$(cat "$(dirname "$(realpath "${BASH_SOURCE[0]}")")"/../RAPIDS_BRANCH)"

dependencies.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,10 @@ dependencies:
275275
- output_types: [conda, requirements]
276276
packages:
277277
- pre-commit
278+
# cargo-fmt pre-commit hook requires a C compiler
279+
- output_types: [conda]
280+
packages:
281+
- c-compiler
278282
clang:
279283
common:
280284
- output_types: conda

docs/source/cuvs_bench/index.rst

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ Docker
8080
We provide images for GPU enabled systems, as well as systems without a GPU. The following images are available:
8181

8282
- `cuvs-bench`: Contains GPU and CPU benchmarks, can run all algorithms supported. Will download million-scale datasets as required. Best suited for users that prefer a smaller container size for GPU based systems. Requires the NVIDIA Container Toolkit to run GPU algorithms, can run CPU algorithms without it.
83-
- `cuvs-bench-datasets`: Contains the GPU and CPU benchmarks with million-scale datasets already included in the container. Best suited for users that want to run multiple million scale datasets already included in the image.
8483
- `cuvs-bench-cpu`: Contains only CPU benchmarks with minimal size. Best suited for users that want the smallest containers to reproduce benchmarks on systems without a GPU.
8584

8685
Nightly images are located in `dockerhub <https://hub.docker.com/r/rapidsai/cuvs-bench/tags>`_.
@@ -97,8 +96,7 @@ The CUDA and python versions can be changed for the supported values:
9796

9897
You can see the exact versions as well in the dockerhub site:
9998
- `cuVS bench images <https://hub.docker.com/r/rapidsai/cuvs-bench/tags>`_
100-
- `cuVS bench with pre-loaded million-scale datasets images <https://hub.docker.com/r/rapidsai/cuvs-bench-cpu/tags>`_
101-
- `cuVS bench CPU only images <https://hub.docker.com/r/rapidsai/cuvs-bench-datasets/tags>`_
99+
- `cuVS bench CPU only images <https://hub.docker.com/r/rapidsai/cuvs-bench-cpu/tags>`_
102100

103101
**Note:** GPU containers use the CUDA toolkit from inside the container, the only requirement is a driver installed on the host machine that supports that version. So, for example, CUDA 11.8 containers can run in systems with a CUDA 12.x capable driver. Please also note that the Nvidia-Docker runtime from the `Nvidia Container Toolkit <https://github.com/NVIDIA/nvidia-docker>`_ is required to use GPUs inside docker containers.
104102

@@ -251,7 +249,7 @@ Usage of the above command is as follows:
251249
- Description
252250

253251
* - `rapidsai/cuvs-bench:26.04-cuda12.9-py3.13`
254-
- Image to use. Can be either `cuvs-bench` or `cuvs-bench-datasets`
252+
- Image to use. See "Docker" section for links to lists of available tags.
255253

256254
* - `"--dataset deep-image-96-angular"`
257255
- Dataset name

0 commit comments

Comments
 (0)