Commit df5cd00
authored
enforce a floor on libnvjitlink, build wheels with CUDA 13.0.x, test wheels against mix of CTK versions (#1862)
The changes from #1405 introduced linking against nvJitLink. nvJitLink has versioned symbols that are added in each new CTK release, and some of those are exposed in `libcuvs.so`.
`libcuvs` wheels are built against the latest CTK supported in RAPIDS (CUDA 13.1.1 as of this writing), so when those wheels are used in environments with older nvJitLink, runtime errors like this can happen:
> libcugraph.so: undefined symbol: __nvJitLinkGetErrorLog_13_1, version libnvJitLink.so.13
For more details, see rapidsai/cugraph#5443
This tries to fix that.
Contributes to rapidsai/build-planning#257
* builds CUDA 13 wheels with the 13.0 CTK
* ensures CUDA 13 wheels ship with a runtime dependency of `nvidia-nvjitlink>={whatever-minor-version-they-were-built-against}`
Contributes to rapidsai/build-planning#256
* updates wheel tests to cover a range of CTK versions (we previously, accidentally, were only testing the latest 12.x and 13.x)
Other changes
* ensures conda packages also take on floors of `libnvjitlink>={whatever-minor-version-they-were-built-against}`
## Notes for Reviewers
### How I tested this
This uses wheels from similar PRs from RAPIDS dependencies, at build and test time:
* NVIDIA/raft#2971
* rapidsai/rmm#2270
* rapidsai/ucxx#604
### Other Options
1. avoiding those versioned symbols with a build-time shim (#1855 does this, but hasn't been successful yet)
2. statically linking libnvJitLink (hasn't been successful yet)
Authors:
- James Lamb (https://github.com/jameslamb)
Approvers:
- Gil Forsyth (https://github.com/gforsyth)
URL: #18621 parent 70dc032 commit df5cd00
4 files changed
Lines changed: 82 additions & 34 deletions
File tree
- ci
- conda/recipes/libcuvs
- python/libcuvs
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
17 | 25 | | |
| 26 | + | |
| 27 | + | |
18 | 28 | | |
19 | 29 | | |
20 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | 137 | | |
141 | 138 | | |
142 | 139 | | |
| |||
150 | 147 | | |
151 | 148 | | |
152 | 149 | | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | 150 | | |
157 | 151 | | |
158 | 152 | | |
| |||
203 | 197 | | |
204 | 198 | | |
205 | 199 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | 200 | | |
210 | 201 | | |
211 | 202 | | |
| |||
219 | 210 | | |
220 | 211 | | |
221 | 212 | | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | 213 | | |
226 | 214 | | |
227 | 215 | | |
| |||
270 | 258 | | |
271 | 259 | | |
272 | 260 | | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | 261 | | |
277 | 262 | | |
278 | 263 | | |
| |||
283 | 268 | | |
284 | 269 | | |
285 | 270 | | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | 271 | | |
290 | 272 | | |
291 | 273 | | |
| |||
436 | 418 | | |
437 | 419 | | |
438 | 420 | | |
439 | | - | |
440 | | - | |
441 | | - | |
442 | 421 | | |
443 | 422 | | |
444 | 423 | | |
| |||
449 | 428 | | |
450 | 429 | | |
451 | 430 | | |
452 | | - | |
453 | | - | |
454 | | - | |
455 | 431 | | |
456 | 432 | | |
457 | 433 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
286 | 286 | | |
287 | 287 | | |
288 | 288 | | |
| 289 | + | |
| 290 | + | |
289 | 291 | | |
290 | 292 | | |
291 | 293 | | |
| |||
314 | 316 | | |
315 | 317 | | |
316 | 318 | | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
| 351 | + | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
317 | 364 | | |
318 | 365 | | |
319 | 366 | | |
| |||
337 | 384 | | |
338 | 385 | | |
339 | 386 | | |
| 387 | + | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
340 | 393 | | |
341 | 394 | | |
| 395 | + | |
342 | 396 | | |
343 | | - | |
344 | | - | |
| 397 | + | |
345 | 398 | | |
346 | | - | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
347 | 403 | | |
348 | | - | |
| 404 | + | |
349 | 405 | | |
350 | 406 | | |
351 | | - | |
| 407 | + | |
| 408 | + | |
352 | 409 | | |
353 | | - | |
| 410 | + | |
| 411 | + | |
354 | 412 | | |
355 | | - | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
356 | 416 | | |
357 | 417 | | |
358 | 418 | | |
359 | | - | |
| 419 | + | |
| 420 | + | |
360 | 421 | | |
361 | 422 | | |
362 | 423 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
0 commit comments