Skip to content

Commit 04c0740

Browse files
authored
Merge pull request #2141 from divyegala/ivf-sq-visibility
Add missing visibility controls in IVF SQ
1 parent 2c5907d commit 04c0740

2 files changed

Lines changed: 11 additions & 4 deletions

File tree

c/include/cuvs/neighbors/ivf_sq.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@
1212
#include <stdbool.h>
1313
#include <stdint.h>
1414

15+
#include <cuvs/core/export.h>
16+
1517
#ifdef __cplusplus
1618
extern "C" {
1719
#endif

cpp/include/cuvs/neighbors/ivf_sq.hpp

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#include "common.hpp"
99
#include <cstdint>
10+
#include <cuvs/core/export.hpp>
1011
#include <cuvs/distance/distance.hpp>
1112
#include <cuvs/neighbors/common.hpp>
1213
#include <raft/core/device_mdarray.hpp>
@@ -15,7 +16,9 @@
1516
#include <raft/core/mdspan.hpp>
1617
#include <raft/util/integer_utils.hpp>
1718

18-
namespace cuvs::neighbors::ivf_sq {
19+
namespace CUVS_EXPORT cuvs {
20+
namespace neighbors {
21+
namespace ivf_sq {
1922

2023
/**
2124
* @defgroup ivf_sq_cpp_index_params IVF-SQ index build parameters
@@ -86,7 +89,7 @@ static_assert(std::is_aggregate_v<search_params>);
8689
*/
8790

8891
template <typename SizeT, typename CodeT, typename IdxT>
89-
struct list_spec {
92+
struct CUVS_EXPORT list_spec {
9093
static_assert(std::is_same_v<CodeT, uint8_t>, "IVF-SQ code type CodeT must be uint8_t");
9194

9295
using value_type = CodeT;
@@ -166,7 +169,7 @@ using list_data = ivf::list<list_spec, SizeT, CodeT, IdxT>;
166169
*
167170
*/
168171
template <typename CodeT>
169-
struct index : cuvs::neighbors::index {
172+
struct CUVS_EXPORT index : cuvs::neighbors::index {
170173
static_assert(std::is_same_v<CodeT, uint8_t>, "IVF-SQ code type CodeT must be uint8_t for now.");
171174

172175
using index_params_type = ivf_sq::index_params;
@@ -625,4 +628,6 @@ void deserialize(raft::resources const& handle,
625628
* @}
626629
*/
627630

628-
} // namespace cuvs::neighbors::ivf_sq
631+
} // namespace ivf_sq
632+
} // namespace neighbors
633+
} // namespace CUVS_EXPORT cuvs

0 commit comments

Comments
 (0)