-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Questions about TorchScript support #30
Comments
Had a similar question regarding torch.compile, does it make sense to put a torch.compile decorator over the FX fallback ? Happy to put in a PR |
@YutackPark : cuEquivariance should be JIT-exportable. We do have jit.trace() unit test in place for underlying cuequivariance_ops_torch, not for this repo yet. |
@YutackPark : actually, we were able to fix script() compatibility (with changes to the API). |
Hi Boris, I tried the newest version that fixed torch.compile() and script() compatibility. Now torch.compile works fine but script is still not working. The problem seems come from some API issues in Is there any feasible way to circumvent using variable number of arguments or keyword-only arguments in Thank you for your support! |
@Yangxinsix : thanks for the input! Please watch out for cuequivariance_ops_torch updated package, should come out soon. |
Hi, I'm exploring the possibility of using cuEquivariance-Torch in a C++ environment, similar to how e3nn models can be exported via TorchScript. I have a few questions:
I attempted to use both
torch.jit.script
andtorch.jit.trace
. While the former raises errors, the latter produces warnings. If it is unexpected, I'll attach a minimal code to reproduce it. Before diving deeper into debugging, I wanted to confirm if there are any related development plans or known limitations.I'm aware that TorchScript may be deprecated in the future. However, its replacement, torch.export (https://pytorch.org/docs/stable/export.html), is still marked as unstable, and I have no option.
Lastly, I've noticed that using
torch.compile
with static tensor shapes can nearly double the performance of e3nn. Could cuEquivariance achieve similar speedups withtorch.compile
, or is this approach less relevant given its use of optimized custom kernels?Thanks in advance for your guidance and support!
The text was updated successfully, but these errors were encountered: