Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHA kernels not triggered in nanoGPT sample #464

Open
yizhuoz004 opened this issue Dec 18, 2024 · 1 comment
Open

MHA kernels not triggered in nanoGPT sample #464

yizhuoz004 opened this issue Dec 18, 2024 · 1 comment
Assignees
@christopherbate
Labels
mlir-tensorrt Pull request for the mlir-tensorrt project performance

Comments

@yizhuoz004
Copy link
Collaborator

nanogpt_mlir.txt
@pranavm-nvidia
Copy link
Collaborator

We should also add a test, maybe using the engine inspector, to make sure that MHA kernels are used where we expect them to be. A perf test would also be a good way to do this since we do ultimately only care about the perf and not really which kernel is used.

@christopherbate christopherbate added the mlir-tensorrt Pull request for the mlir-tensorrt project label Jan 23, 2025
@christopherbate christopherbate self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christopherbate christopherbate

Labels
mlir-tensorrt Pull request for the mlir-tensorrt project performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christopherbate @pranavm-nvidia @yizhuoz004