Installer failed at onboarding: Cannot find module

[subbyte]

Description

The installer failed again on the latest commit 86b3dee.
See log for details.

Reproduction Steps

1. Install NemoClaw on Fedora 43 via curl -fsSL https://www.nvidia.com/nemoclaw.sh | bash

Environment

• OS: Fedora 43 (Linux 6.19.10-200)
• NodeJS: v22.22.2 (installed by the installer)
• Docker: Docker CE 29.3.1
• NemoClaw: 86b3dee

Debug Output

Logs

[1/3] Node.js
  ──────────────────────────────────────────────────
[INFO]  Node.js not found — installing via nvm…
[INFO]  nvm installer integrity verified
  ✓  Installing nvm...
  ✓  Installing Node.js 22...
default -> 22 (-> v22.22.2)
[INFO]  Node.js installed: v22.22.2
[INFO]  Runtime OK: Node.js v22.22.2, npm 10.9.7

[2/3] NemoClaw CLI
  ──────────────────────────────────────────────────
[INFO]  Installing NemoClaw from GitHub…
[INFO]  Resolved install ref: latest
  ✓  Cloning NemoClaw source
  ✓  Preparing OpenClaw package
  ✓  Installing NemoClaw dependencies
  ✓  Building NemoClaw CLI modules
  ✓  Building NemoClaw plugin
  ✓  Linking NemoClaw CLI
[INFO]  Verified: nemoclaw is available at /home/u/.nvm/versions/node/v22.22.2/bin/nemoclaw

[3/3] Onboarding
  ──────────────────────────────────────────────────
[INFO]  Installer stdin is piped; attaching the usage notice to /dev/tty…
node:internal/modules/cjs/loader:1386
  throw err;
  ^

Error: Cannot find module '/home/u/bin/lib/usage-notice.js'
    at Function._resolveFilename (node:internal/modules/cjs/loader:1383:15)
    at defaultResolveImpl (node:internal/modules/cjs/loader:1025:19)
    at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1030:22)
    at Function._load (node:internal/modules/cjs/loader:1192:37)
    at TracingChannel.traceSync (node:diagnostics_channel:328:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:237:24)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
    at node:internal/main/run_main_module:36:49 {
  code: 'MODULE_NOT_FOUND',
  requireStack: []
}

Node.js v22.22.2

I checked that /home/u/bin/lib/ does not exist.

Checklist

• I confirmed this bug is reproducible
• I searched existing issues and this is not a duplicate

[xiaobai012910]

i have same issue:
[3/3] Onboarding
──────────────────────────────────────────────────
[INFO] Installer stdin is piped; attaching the usage notice to /dev/tty…
node:internal/modules/cjs/loader:1386
throw err;
^

Error: Cannot find module '/home/xiaobai/bin/lib/usage-notice.js'
at Function._resolveFilename (node:internal/modules/cjs/loader:1383:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1025:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1030:22)
at Function._load (node:internal/modules/cjs/loader:1192:37)
at TracingChannel.traceSync (node:diagnostics_channel:328:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:237:24)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:171:5)
at node:internal/main/run_main_module:36:49 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}

Node.js v22.22.2

[latenighthackathon]

Note: #1381 is a duplicate of this issue. Also related to the prior #655 fix — that PR added the ${BASH_SOURCE[0]:-$0} fallback but $0 resolves to bash when piped, so SCRIPT_DIR still points to cwd instead of the clone directory.

[latenighthackathon]

Proposed fix: Two changes to install.sh:

1. Update SCRIPT_DIR after cloning

When piped via curl | bash, SCRIPT_DIR resolves to the user's cwd (because BASH_SOURCE[0] is empty and $0 is bash). After the clone completes, SCRIPT_DIR is never updated to point at the cloned source, so show_usage_notice() looks for usage-notice.js in the wrong directory.

     spin "Linking NemoClaw CLI" bash -c "cd \"$nemoclaw_src\" && npm link"
+    SCRIPT_DIR="$nemoclaw_src"
   fi

Same fix for the local-source install path:

     spin "Linking NemoClaw CLI" npm link
+    SCRIPT_DIR="$(pwd)"
   else

2. Guard show_usage_notice() against missing file

The latest tag currently points to b999c0e which predates the usage-notice.js addition in #1290. Even with the SCRIPT_DIR fix, the cloned source won't have the file until the tag is moved. Adding a guard prevents the crash:

 show_usage_notice() {
+  if [[ ! -f "${SCRIPT_DIR}/bin/lib/usage-notice.js" ]]; then
+    return 0
+  fi
   local -a notice_cmd=(node "${SCRIPT_DIR}/bin/lib/usage-notice.js")

Tested in Docker (Ubuntu 24.04, clean install, piped via cat install.sh | bash):

• Unpatched: Cannot find module '/home/testuser/bin/lib/usage-notice.js' (wrong path)
• SCRIPT_DIR fix only: Cannot find module '/home/testuser/.nemoclaw/source/bin/lib/usage-notice.js' (correct path, file missing due to stale tag)
• Both fixes: Installer completes through to nemoclaw onboard successfully

PR incoming.