Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HF training items for future-proof #3161

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes JIRA FLARE-2332 on main branch.

Description

Add HF lib version, and remove HF training config items that are either outdated already or to be deprecated in next release

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77
Copy link
Collaborator Author

similar to the update on 2.5 branch, add version and updates to 1) fit the latest and 2) avoid future deprecation warning

@ZiyueXu77
Copy link
Collaborator Author

/build

@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) January 21, 2025 19:04
@YuanTingHsieh
Copy link
Collaborator

/build

@ZiyueXu77 ZiyueXu77 merged commit cefc4e8 into NVIDIA:main Jan 22, 2025
20 checks passed
@ZiyueXu77 ZiyueXu77 deleted the hf_version branch January 23, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants