Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Fix external configurator #3159

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Conversation

yanchengnv
Copy link
Collaborator

Fixes # .

Description

To support explicit message authentication and connection security, messages from external processes (client API based) must include auth token and signature. This PR modifies the ExternalConfigurator to export these properties to allow the external process to obtain them.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yanchengnv yanchengnv enabled auto-merge (squash) January 21, 2025 14:54
@yanchengnv
Copy link
Collaborator Author

/build

1 similar comment
@yanchengnv
Copy link
Collaborator Author

/build

@yanchengnv yanchengnv disabled auto-merge January 21, 2025 18:07
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the same logic is used in other places, we could try to create a general method for easy reusing

@YuanTingHsieh
Copy link
Collaborator

/build

@YuanTingHsieh YuanTingHsieh merged commit b75d03f into NVIDIA:2.5 Jan 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants