Skip to content

Commit 66246fd

Browse files
committed
reinstall horovod in multi-gpu gha
1 parent dbb7af7 commit 66246fd

File tree

2 files changed

+15
-28
lines changed

2 files changed

+15
-28
lines changed

examples/usecases/multi-gpu/install_distributed_embeddings.sh

Lines changed: 0 additions & 24 deletions
This file was deleted.

tox.ini

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ commands =
2828
; Runs in: Github Actions
2929
; Runs GPU-based tests.
3030
allowlist_externals =
31+
git
3132
horovodrun
33+
make
3234
deps =
3335
-rrequirements/test.txt
3436
passenv =
@@ -37,11 +39,22 @@ setenv =
3739
TF_GPU_ALLOCATOR=cuda_malloc_async
3840
sitepackages=true
3941
commands =
40-
# Install Merlin packages
42+
# Install Merlin packages.
4143
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git@{posargs:main}
4244
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git@{posargs:main}
4345
python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/nvtabular.git@{posargs:main}
44-
# Run multi-gpu tests marked with `horovod` marker
46+
# Reinstall Horovod using `pip install --no-cache-dir` to build with the new version.
47+
{envdir}/env/bin/python -m pip install horovod --no-cache-dir
48+
{envdir}/env/bin/horovodrun --check-build
49+
# Install distributed-embeddings.
50+
git clone https://github.com/NVIDIA-Merlin/distributed-embeddings.git
51+
cd distributed-embeddings
52+
git submodule update --init --recursive
53+
make pip_pkg
54+
python -m pip install --force-reinstall artifacts/*.whl
55+
python setup.py install
56+
python -c "import distributed_embeddings"
57+
# Run multi-gpu tests marked with `horovod` marker.
4558
horovodrun -np 2 sh examples/usecases/multi-gpu/hvd_wrapper.sh pytest -m horovod -rxs tests/unit
4659

4760
[testenv:py38-horovod-cpu]
@@ -58,8 +71,6 @@ commands =
5871
# Install horovod and check build
5972
{envdir}/env/bin/python -m pip install horovod --no-cache-dir
6073
{envdir}/env/bin/horovodrun --check-build
61-
# Install distributed embeddings and check build
62-
bash examples/usecases/multi-gpu/install_distributed_embeddings.sh {envtmpdir}
6374
# Install Merlin packages
6475
{envdir}/env/bin/python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/core.git
6576
{envdir}/env/bin/python -m pip install --upgrade git+https://github.com/NVIDIA-Merlin/dataloader.git

0 commit comments

Comments
 (0)