Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relative paths in test data #104

Open
cefect opened this issue Jan 10, 2025 · 1 comment
Open

relative paths in test data #104

cefect opened this issue Jan 10, 2025 · 1 comment
Assignees
@ceftanveer
Labels
bug Something isn't working

Comments

@cefect
Copy link
Collaborator

cefect commented Jan 10, 2025 •
edited
Loading

it looks like some of the test data (mostly control files?) has hard coded paths. I thought this was fixed, but I guess not. also, the filepath assertion errors are not failing the pytest for some reason (error messgae is displayed on std.out, but test still passes).

fix hard-coded paths in all the test data
@cefect cefect added the bug Something isn't working label Jan 10, 2025
@ceftanveer ceftanveer mentioned this issue Jan 15, 2025
Merged
@cefect cefect closed this as completed Jan 22, 2025
@cefect cefect reopened this Jan 24, 2025
@cefect
Copy link
Collaborator Author

cefect commented Jan 25, 2025

PR #110 was not a complete fix.

@cefect cefect mentioned this issue Jan 25, 2025
Merged
2 tasks
@ceftanveer ceftanveer mentioned this issue Feb 8, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceftanveer ceftanveer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

104-relative-paths-in-test-data NRCan/CanFlood
2 participants
@cefect @ceftanveer