Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check implicit bottom friction #85

Open
jasontempestholt opened this issue Nov 21, 2022 · 2 comments
Open

Check implicit bottom friction #85

jasontempestholt opened this issue Nov 21, 2022 · 2 comments
Assignees

Comments

@jasontempestholt
Copy link
Collaborator

Currently Implicit bottom friction is only activated in dynspg_ts with wetting drying because of bit comparison issue. May help bottom friciton stability issues

@jasontempestholt jasontempestholt changed the title Check Implicity bottom friction Check implicit bottom friction Nov 21, 2022
@jasontempestholt
Copy link
Collaborator Author

In current version of dynspg_ts.F90

Line 648
! Add bottom stresses:
!jth do implicitly instead
IF ( .NOT. ll_wd ) THEN ! Revert to explicit for bit comparison tests in non wad runs
DO_2D( 0, 0, 0, 0 )
zu_trd(ji,jj) = zu_trd(ji,jj) + zCdU_u(ji,jj) * un_e(ji,jj) * hur_e(ji,jj)
zv_trd(ji,jj) = zv_trd(ji,jj) + zCdU_v(ji,jj) * vn_e(ji,jj) * hvr_e(ji,jj)
END_2D

Line 711
!jth implicit bottom friction:
IF ( ll_wd ) THEN ! revert to explicit for bit comparison tests in non wad runs
DO_2D( 0, 0, 0, 0 )
ua_e(ji,jj) = ua_e(ji,jj) / ( 1._wp - rDt_e * zCdU_u(ji,jj) * hur_e(ji,jj) )
va_e(ji,jj) = va_e(ji,jj) / ( 1._wp - rDt_e * zCdU_v(ji,jj) * hvr_e(ji,jj) )
END_2D
ENDIF

@jasontempestholt jasontempestholt self-assigned this Nov 21, 2022
@jasontempestholt
Copy link
Collaborator Author

Stability criteria is:

U<H/(DT.Cd)

So only an issue in shallow water, but

10/(900x0.01)=1
So care may be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants