+get_param unit description cleanup #238
Merged
+17
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MitchBushuk
approved these changes
Jan 7, 2026
Contributor
MitchBushuk
left a comment
MitchBushuk
left a comment
There was a problem hiding this comment.
This PR makes some basic text and units cleanup, and looks to be all correct.
Cleaned up various aspects of the units arguments to `get_param()` calls to
follow the patterns used elsewhere in the SIS2 and MOM6 code. These include:
- 2 instances where the units arguments were moved to be on the same line as the
default arguments.
- 6 instances where "m/s" or "g/kg" were changed to "m s-1" or "g kg-1" to
align with CMIP standard syntax.
- 8 instances where there was extra space around the name assignment of an
argument (e.g., changing 'units = ...' to 'units=...'.
- 1 instance where the units of "none" were changed to "nondim"
In addition, an unused and unlogged call to read ICE_BULK_SALNITY was eliminated
from ice_model_init. All solutions are bitwise identical, but there are minor
formatting changes to the units logged in the SIS_parameter_doc files for some
variables.
Hallberg-NOAA
force-pushed
the
units_argument_cleanup
branch
from
d89f941 to
189dc3c
Compare
Member
Author
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/SIS2/-/pipelines/29838 with the expected warnings about changes to the units in the SIS_parameter_doc files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up various aspects of the units arguments to
get_param()calls to follow the patterns used elsewhere in the SIS2 and MOM6 code. These include:In addition, an unused and unlogged call to read ICE_BULK_SALNITY was eliminated from ice_model_init. All solutions are bitwise identical, but there are minor formatting changes to the units logged in the SIS_parameter_doc files for some variables.