Skip to content

Add placeholders for ecflow suite and job cards#210

Open
CoryMartin-NOAA wants to merge 17 commits into
mainfrom
feature/ecflow
Open

Add placeholders for ecflow suite and job cards#210
CoryMartin-NOAA wants to merge 17 commits into
mainfrom
feature/ecflow

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Apr 30, 2026

Initial start to ecflow suite definition file and job cards for marine observation processing for GFSv17 for Obsforge v1.0.

@CoryMartin-NOAA CoryMartin-NOAA self-assigned this Apr 30, 2026
@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented Apr 30, 2026

Note this PR is into main but once it is merged a "cherry-picked" commit will be made to dev/obsforge.v1

HyundeokChoi-NOAA
HyundeokChoi-NOAA reviewed May 1, 2026
View reviewed changes
Comment thread ecf/scripts/gdas/jobsforge_gdas_marine_bufr_dump.ecf
############################################################
# CALL executable job script here
############################################################
${HOMEobsforge}/jobs/JOBSFORGE_GDAS_MARINE_BUFR_DUMP
Copy link
Copy Markdown
Contributor

@HyundeokChoi-NOAA HyundeokChoi-NOAA May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current obsForge implementation does not distinguish between GDAS and GFS jobs and scripts. Both use the same job/scripts because their processing logic is identical. Do we still need to make them separately?

Copy link
Copy Markdown
Contributor Author

@CoryMartin-NOAA CoryMartin-NOAA May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short answer, yes. Just documenting it here that we will want separate jobs for production but can have one job for development mode/in the GitHub main branch.

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

CoryMartin-NOAA commented May 11, 2026

@copilot resolve the merge conflicts in this pull request and ask me if you run into any issues

@CoryMartin-NOAA
Merge origin/main into feature/ecflow to resolve merge conflicts
15273aa 
Co-authored-by: CoryMartin-NOAA <6354668+CoryMartin-NOAA@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot resolve the merge conflicts in this pull request and ask me if you run into any issues

Merged main into feature/ecflow in commit 15273aa. There were no actual conflicts — Git auto-merged everything cleanly. The main changes brought in from main (PR #214) were:

  • jobs directory is now a symlink to dev/jobs/
  • Dev job scripts and rocoto cards moved to dev/job_cards/ and dev/jobs/
  • dev/ush/of_setup.sh relocated
  • Various parm XML template updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HyundeokChoi-NOAA HyundeokChoi-NOAA HyundeokChoi-NOAA left review comments

@givelberg givelberg Awaiting requested review from givelberg

@apchoiCMD apchoiCMD Awaiting requested review from apchoiCMD

At least 1 approving review is required to merge this pull request.

Assignees

@CoryMartin-NOAA CoryMartin-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CoryMartin-NOAA @HyundeokChoi-NOAA