Configuration for the MOM6 increment QC#232
Merged
guillaumevernieres merged 1 commit intorelease/1.0from Mar 3, 2026
Merged
Conversation
9 tasks
shlyaeva
reviewed
Mar 2, 2026
Collaborator
shlyaeva
left a comment
shlyaeva
left a comment
There was a problem hiding this comment.
Should we also turn off the ice thickness updates in soca2cice here?
Contributor
Author
Same comment as the other PR. We'll have to run separate testing for the ice thickness fix, so separate PR/hotfix. |
DavidNew-NOAA
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
I have no immediate objections.
I think long term, the lists of variables you're modifying here and everywhere in jcb-gdas should be defined in jcb-base.yaml.j2, so that they're all defined in once place. Not really relevant to this PR, just noticing.
guillaumevernieres
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Mar 3, 2026
# Description Copy/pasted from [JCSDA-internal/soca/pull/1223](JCSDA-internal/soca#1223): This PR adds increment quality control (QC) utilities to SOCA to enforce physical consistency of ocean analysis increments prior to output. The new functionality applies configurable bounds on temperature and salinity increments, checks and corrects water column stability to prevent density inversions, and constrains steric height contributions to limit unrealistic SSH increments. Density calculations use the UNESCO 1983 equation of state, and the QC can be applied iteratively with optional smoothing. The QC is integrated into the ensemble analysis postprocessing workflow via a new qcIncrement() call in AnalysisPostproc, ensuring that all analysis increments satisfy physical constraints before being written out. This PR adds new functionality; changes in analysis increments are expected when QC thresholds are active, particularly in regions or cycles with large or unbalanced increments. # Companion PRs - NOAA-EMC/jcb-gdas#232 - NOAA-EMC/soca#3 # Issues Resolves # # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !--> - [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA !--> - [ ] C48_ufsenkf_atmDA <!-- JEDI atm EnKF cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...