Skip to content

Rwps mesh gen tools with plots#87

Open
kestonsmith-noaa wants to merge 49 commits intoNOAA-EMC:developfrom
kestonsmith-noaa:RWPSMeshGenToolsWithPlots
Open

Rwps mesh gen tools with plots#87
kestonsmith-noaa wants to merge 49 commits intoNOAA-EMC:developfrom
kestonsmith-noaa:RWPSMeshGenToolsWithPlots

Conversation

@kestonsmith-noaa
Copy link

@kestonsmith-noaa kestonsmith-noaa commented Feb 19, 2026

Pull Request Summary

This adds routines for basic plotting of data inputs and output unstructured mesh to regional mesh generation tools

Description

Adds routines for basic plotting of data inputs and output unstructured mesh to regional mesh generation tools. Plots are generated in .jpg format within a "-nodisplay -nodesktop " environment, such as on most HPC systems. Plots topography input, boundary PSLG, Distance to coast and output mesh bathymetry and resolution. Quick start instructions for regional mesh generation: https://docs.google.com/document/d/1xCVjOLjiQEbnbjVPFZA1CYGCMf86zGvb3N3JoQfZa04

suggested reviewer: Ali Salimi

Issue(s) addressed

Commit Message

Adds routines for basic plotting of data inputs and output unstructured mesh to regional mesh generation tools

Check list

  • Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.

Testing

  • How were these changes tested?
    Scripts were run to generate a sample north western coastal mesh as well as an RWPS type mesh using modified coastline around New Orleans.

…nged from insidepoly toolbox to inpoly2 to simplify download and improve support.
…ame, and added all nescesarry files for local mesh example
…ed bug in RWPS mesh generation testcase involoving topography file
@JessicaMeixner-NOAA
Copy link
Collaborator

@kestonsmith-noaa -- Doing a quick look, this looks like a lot of like what is in #86 instead of just the subset of updates that are just the plotting routine updates.

@kestonsmith-noaa
Copy link
Author

The graphics calls are integrated into the mesh generation scripts, so there are changes with in the material in PR#86. I also ran into a problem in testing this version and made one of the coastline processing files more robust. Maybe I should just start with a fresh pull request covering the material in 86 and 87.

@JessicaMeixner-NOAA
Copy link
Collaborator

Please do not start over!

It seems my understanding that these were independent plotting tools was incorrect. If the plots are working bring them into the other PR.

If something is not working - please make comments in the PR, so we are aware of what is and is not working. The understanding otherwise is that you're just waiting for review. Please keep the PR open and comments up to date as things change.

@kestonsmith-noaa
Copy link
Author

OK. Will make the changes within PR #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants