Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis read-only replica support #1019

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

gthess
Copy link
Member

@gthess gthess commented Feb 23, 2024

This PR introduces a Redis replica server next to an Redis server that is assumed to be in read-only mode.
If configured, Redis read commands will go there while write commands will go to the non-replica server.
All connectivity options are duplicated for the replica server.
Redis tests are not yet implemented.

@gthess gthess self-assigned this Feb 23, 2024
@madnuttah
Copy link

madnuttah commented Feb 23, 2024

Hi @gthess, does this imply this workaround for dockerized Unbound ain't necessary anymore then?

@gthess
Copy link
Member Author

gthess commented Feb 27, 2024

Hi @madnuttah, I am not sure what the workaround is in that link but I see no relation with this feature. This feature adds support for Unbound to issue all read commands to a Redis replica server, offloading most of the of the work from the main Redis server which will only be issued write commands.
Does that answer your question?

@madnuttah
Copy link

Thanks for making it clear!

@gthess gthess marked this pull request as ready for review December 31, 2024 15:12
@gthess
Copy link
Member Author

gthess commented Dec 31, 2024

There was some time investment to bring this up to speed with recent changes so I think it is time to merge to avoid the same time investment in the future.
Since this is a PR already, I'll wait for a review before squash merging.

@gthess gthess requested a review from wcawijngaards December 31, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants