Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support migrations using non-disk storage #1094

Closed
6 tasks done
timbru opened this issue Jul 7, 2023 · 0 comments · Fixed by #1099
Closed
6 tasks done

Support migrations using non-disk storage #1094

timbru opened this issue Jul 7, 2023 · 0 comments · Fixed by #1099

Comments

@timbru
Copy link
Contributor

timbru commented Jul 7, 2023 •
edited
Loading

No longer require that "upgrade_storage_uri" is set. This will enable migrations that use non-disk storage in future, but it should be noted that the migration from disk to non-disk (postgresql) storage is a separate step that should only be done after upgrading to 0.14.0 - see issue #1079.

  • Update kvx to support namespace migrations.
  • Remove upgrade_storage_uri from Config
  • Remove all direct file / directory access in upgrade code (use KV instead)
  • Move data_dir_from_storage_uri to Config (only used for tls_dirs, repo_dir and pid_file)
  • Move storage_uri_from_data_dir to Config
  • Use the in-memory data store for automated upgrade tests (make this configurable)

Note: issue #1098 was made to improve version upgrades in clustered setups.
@timbru timbru mentioned this issue Aug 30, 2023
Closed
@timbru timbru linked a pull request Aug 30, 2023 that will close this issue
Support migrations using non-disk storage #1094 #1099
Merged
timbru pushed a commit that referenced this issue Sep 21, 2023
Support migrations using non-disk storage #1094
2b17a1c 
* Use kvx with explicit namespace type.
* Do not depend on a data dir for storage.
* Fix upgrade code.
@timbru timbru closed this as completed Sep 21, 2023
timbru pushed a commit that referenced this issue Oct 17, 2023
Support migrations using non-disk storage #1094
263d870 
* Use kvx with explicit namespace type.
* Do not depend on a data dir for storage.
* Fix upgrade code.
@timbru timbru mentioned this issue Oct 25, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in 0.14.x Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
0.14.x
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support migrations using non-disk storage #1094 NLnetLabs/krill
1 participant
@timbru