[Bug]: Class "Icinga\Module\Grafana\Controllers\Grapher" not found

[littleprivate]

Please try to fill out as much of the information below as you can. Thank you!

• Yes, I've searched similar issues on GitHub and didn't find any.

Which version contains the bug?

No response

Describe the bug

I'm getting error message in a fresh installation with the latest release of the icingaweb2-module-grafana:

Error in /usr/share/icingaweb2/modules/grafana/application/controllers/DashboardController.php:52 with message: Class "Icinga\Module\Grafana\Controllers\Grapher" not found #0 /usr/share/icinga-php/vendor/vendor/shardj/zf1-future/library/Zend/Controller/Action.php(516): Icinga\Module\Grafana\Controllers\DashboardController->indexAction() #1 /usr/share/php/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch() #2 /usr/share/icinga-php/vendor/vendor/shardj/zf1-future/library/Zend/Controller/Front.php(954): Icinga\Web\Controller\Dispatcher->dispatch() #3 /usr/share/php/Icinga/Application/Web.php(294): Zend_Controller_Front->dispatch() #4 /usr/share/php/Icinga/Application/webrouter.php(105): Icinga\Application\Web->dispatch() #5 /usr/share/icingaweb2/public/index.php(4): require_once(String) #6 {main}

My environment:

Icinga Web 2 2.12.5
Git Commit e0836c569734d6414c307ec0094cfed9a9dce694
PHP Version 8.1.2-1ubuntu2.22
MODULE VERSION
aws 1.1.0
businessprocess 2.4.1
icingadb 1.1.3
cube 1.3.3
director 1.11.5
doc 2.12.5
grafana 3.1.1
incubator 0.22.0
ipl v0.5.0
monitoring 2.12.5
reactbundle 0.9.0
translation 2.12.5

How to recreate the bug?

Refreshing any graph in icingaweb2 or page reload

[martialblog]

Hi, you are using IcingaDB I assume?

It's curious, the code that is causing the error is quite old and should not be called when IcingaDB is active.

81a4d5a2 (2018-05-08 12:13:07 +0200 52)         $graph = new Grapher();
81a4d5a2 (2018-05-08 12:13:07 +0200 53)         $this->view->graph = $graph->getPreviewHtml($object);

The Grapher class does not exist anymore, probably a leftover from an earlier version.

[littleprivate]

Hi, yes I'm using IcingaDB as described in the requirements.
The module was cloned by the repository.

[martialblog]

I haven't been able to recreate the error. Since it's in the DashboardController, I assume you created a dashboard with a graph?

Since we don't support the IDO/Monitoring module anymore, we can probably just remove the code.

[martialblog]

@littleprivate Could you test this branch please https://github.com/NETWAYS/icingaweb2-module-grafana/tree/remove-legacy

I'm not 100% what causes your instance to run into the old code.

[littleprivate]

Hi,
I've testet the branch, the error message went away :-)

Thank you!

[martialblog]

Fixed with #75