Check (but not fix) Fortran format in GitHub actions #717
+92
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
force-pushed
the
feature/codee_ci
branch
3 times, most recently
from
64b1798 to
4cc9c80
Compare
climbfuji
force-pushed
the
feature/codee_ci
branch
2 times, most recently
from
8e7925c to
e115fe9
Compare
climbfuji
force-pushed
the
feature/codee_ci
branch
from
e115fe9 to
6214664
Compare
climbfuji
changed the title
climbfuji
commented
Jan 22, 2026
| !!XXgoldyXX: To do, statistics output | ||
| module ccpp_hash_table | ||
|
|
||
| ! Modify this file ... |
Collaborator
Author
There was a problem hiding this comment.
Lines 4-5 will be removed before merging the PR, this will allow the newly added test to pass.
dustinswales
approved these changes
Feb 2, 2026
Member
dustinswales
left a comment
dustinswales
left a comment
There was a problem hiding this comment.
@climbfuji This is great. Thanks!
I wonder if we could add a github secret and allow the workflow to be run from forks?
(I will look into this...)
| # echo "Formatting issues detected. Run 'codee format' locally or attach label 'fix-fortran-format' to this PR." | ||
| # exit 1 | ||
| # | ||
| # This doesn't work if the pull request comes from a fork ... |
Member
There was a problem hiding this comment.
Maybe we could we use a github token with appropriate permissions?
Collaborator
Author
There was a problem hiding this comment.
It's complicated. You need to configure a PAT for every single individual who creates a PR. Not worth the effort imo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check (but not fix) Fortran format in GitHub actions.
Note. The newly added GitHub actions workflow is currently failing intentionally to illustrate how the setup works. The temporary change to the Fortran source code that triggers this failure will be reverted so that all tests pass before this PR is merged.
This PR enables automated checking of the Fortran format using Codee in GitHub actions. The new test will fail if running Codee updates files that are modified in a pull request. The system tells the user to either run Codee locally (which is almost trivial when following the GitHub workflow) or applying a diff that the system produces.
This PR does not enable automatic reformatting and updates of pull requests, because this doesn't work if the pull request comes from a fork (which we usually require for the ccpp-framework repository). The stencil code to do this is submitted as comment in the current PR, however.
The checking is limited to the static Fortran source files in this repository, not the auto-generated Fortran code from
capgenorprebuild- this will be addressed in a future PR.While at it, I updated the existing GitHub workflows to run on
developonly, sincemainis now frozen`, and to avoid concurrent workflow runs (i.e. cancel currently running tests from the same pull request if an update is pushed).User interface changes?: No
Working toward #703
Testing:
test removed: n/a
unit tests: all pass
system tests: all pass (see note above about newly added test)
manual testing: n/a
test added: GitHub actions test to check formatting of static Fortran source files in this repository