Open
Conversation
dmocko
added
enhancement
Not that unused subroutine and function arguments were left in place, to keep the call signatures undisturbed. The existence of unused arguments is found in other LSM interfaces, and this should be fixed in a more widespread (and separate) pull request.
Contributor
|
Since @jvgeiger is wrapping up a different PR before working on this one, I took the liberty of test compiling the code. Compilation was successful (using the Intel 2023.2.1 compiler), but strict checks indicated quite a few unused variables. I went ahead and pushed changes to remove most of these variables and save a little memory. (Unused arguments are left undisturbed.) |
jvgeiger
reviewed
Feb 14, 2025
lis/surfacemodels/land/noahmp.5.0/routing/noahmp50_getrunoffs_hymap2.F90
Show resolved
Hide resolved
This file/routine is not used in NoahMPv5.
These files/routines are not needed anymore. This interface was removed.
I am replacing these with tests from David Mocko.
These came from David Mocko.
Contributor
|
@dmocko , I pushed my commits into the pull request. I believe that I resolved all the issues that we discussed. Would you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to submit the code update of coupling Noah-MPv5.0 with LIS through the GitHub submodule mechanism.
Code contributor: Cenlin He (NCAR; [email protected])
Model test contributors: Cenlin He (NCAR), Tzu-Shun Lin (NCAR), David Mocko (NASA/LIS)