Noah-MP Miguez-Macho and Fan by TimLahmers · Pull Request #1418 · NASA-LIS/LISF

TimLahmers · 2023-09-22T18:11:58Z

Description

This PR includes support for the Miguez-Macho and Fan Groundwater scheme (Miguez-Macho et al. 2007). This scheme allows 2-way sub-surface routing in the Noah-MP v.4.0.1 LSM in serial and parallel processor configurations. A halo size of at least 3 grid points is recommended for stable results in parallel. The Miguez-Macho and Fan scheme is not recommended for grid resolutions higher than 4-km due to assumptions for the channel exfiltration (QRF) calculation becoming unrealistic at high resolutions.

Resolves #1037

Requires PR #1407 to support ISRIC soils

Testcase

LDT: /discover/nobackup/tlahmers/SHARE/MMF_Testcases/LDT_run
LIS: /discover/nobackup/tlahmers/SHARE/MMF_Testcases/LIS_run

…ater than forcing dt

…atements

… updates.

…P401 runoff modes.

…ATSGO.

sudarsan3010 · 2024-01-25T15:03:20Z

So, the MMF scheme in Noah-MP is now ready to use? Is it already merged with the master?
I am waiting from a very long time to use this sub-surface scheme.

dmocko · 2024-07-10T17:35:11Z

lis/surfacemodels/land/noahmp.4.0.1/NoahMP401_coldstart.F90

+             wtddt = NOAHMP401_struc(n)%ts/60.0 ! wtddt in minute? 
             stepwtd = 0
-             dtbl = 0.0
+             dtbl = NOAHMP401_struc(n)%ts


I note that "dtbl" is not used anywhere else in the code (including within the "phys" sub-directory).

@dmocko This might be an artifact from earlier code changes, before I took over the MMF coding. If this doesn't appear anywhere else in the code or affect other LIS components, I am open to removing it.

dmocko · 2024-07-10T17:36:34Z

lis/surfacemodels/land/noahmp.4.0.1/NoahMP401_lsmMod.F90

+                                                    NOAHMP401_struc(n)%row_min:NOAHMP401_struc(n)%row_max))
+                allocate(NOAHMP401_struc(n)%vege3d(NOAHMP401_struc(n)%col_min:NOAHMP401_struc(n)%col_max, &
+                                                    NOAHMP401_struc(n)%row_min:NOAHMP401_struc(n)%row_max, &
+                                                    20)) ! 20 is the number of surfacetype categories, hardcoded temporarily 


This line should be changed, so 20 is not hard-coded. Please change to number of vegetation classes.

@dmocko Consistent with the change proposed below in the NoahMP401_setup.F90 module, could we change the hard-coded value to LIS_rc%nsurfacetypes? Similarly, we could use LIS_rc%nsoiltypes for the number of soils.

Yes, I believe that this will work.

dmocko · 2024-07-10T17:38:30Z

lis/surfacemodels/land/noahmp.4.0.1/NoahMP401_setup.F90

+
+                    ! if the total fraction from layer 1 to layer 20 is no more than 0.5, this means there is the fraction of the 21st layer is >= 0.5, set the landcover type to be 17 as HRLDAS
+                    if(.not. sum(NOAHMP401_struc(n)%vege3d(cidx, ridx, :))>0.5) then
+                        NOAHMP401_struc(n)%vege2d(cidx,ridx) = 17


I don't think "17" should be hard-coded here. Instead, please set to the water type within LIS, so it covers all vegetation classifications that might be used.

@dmocko Something similar also came up for another version of MMF (the GWS project that Wanshu and I started). Is something like this what you are looking for? a3a6114

Sort of. I was thinking more about "LIS_rc%waterclass", which is read in from WATERCLASS from the lis_input file.

dmocko · 2024-07-10T17:52:29Z

Hi @TimLahmers and @jvgeiger

I'm finally getting around to reviewing this PR for MMF. My apologies for taking so long to finish it.
May all my jobs this week sit on the queue for an extra 12 hours as penance!

I made a few specific comments about code above, but more generally most of these changes look good to me.

I do wonder, though - What is the difference between the variables “LIS_rc%nsurfacetypes” and “LIS_rc%nvegtypes”?
In NoahMP401_setup.F90, Lines 370 and 386 go from 1 to LIS_rc%nsurfacetypes. Should this be LIS_rc%nvegtypes?

As a test, I ran in the NLDAS-2 domain using both the latest main/master branch and using the code in this PR.
For this test, I am using the TOPWATER groundwater scheme - in other words, I am NOT using the MMF scheme.
All of the variables - EXCEPT for RelSMC - produced identical output (as expected) between the two runs.
Note that these test runs both use the UMD vegetation classification, which show that results could be affected
by the hard-coding described above.

@TimLahmers - Can you please take a look at this output field?

This is RelSMC from the main branch:

This is RelSMC from the code for this PR:

This is the difference between the two fields:

There are two issues:

In the run with the MMF code, there's a strip of undefined values from DC south through VA and NC.
In the run with the MMF code, there are values for the urban type, while from the main code, these values are undefined. They should be undefined according to the code. The difference field shows that outside of these two areas (DC to VA to NC strip - and - urban points), the values are identical between these two runs.

…_mmf

…in loop w/MMF code addition

dmocko · 2024-08-14T16:56:11Z

lis/surfacemodels/land/noahmp.4.0.1/NoahMP401_main.F90

+            xice(:,:)      = 0.0 ! ice fraction is 0
+            xice_threshold = 0.5 ! be consistent with hrldas 
+            isice          = 100 ! this number should not be one of vegetation type id 
+            isurban        = 13  ! be consistent with hrldas 


Hi @TimLahmers - this is another hard-coded value that should be generalized.

Can you please change the "13" to LIS_rc%urbanclass ?

@TimLahmers - One other question about hard-coding the ice values in lines 1029-1032.

Hard-coding these values will run the MMF groundwater for all glacier points in LIS.

However, the code itself seems to check if it is a glacier/ice point, and possibly not run these points:

WHERE(XLAND-1.5.LT.0..AND.XICE.LT. XICE_THRESHOLD.AND.IVGTYP.NE.ISICE) LANDMASK=1 ELSEWHERE LANDMASK=-1 ENDWHERE

Can you please comment on why you are making MMF run for all glacier/ice points?

@dmocko I had a chance to check on this today. It looks like the lines related to glacier points are copied from HRLDAS. Is there a reason we shouldn't run MMF for glacier/ice points? If there is a scientific justification for not running this way, we could raise this at the next Noah-MP telecon.

dmocko · 2024-08-14T17:01:07Z

Once @TimLahmers changes the urban type from my most recent comment, can you (Tim) please re-run your testcase?

I now get identical results from the RELSMC output, so that issue is resolved. Thanks!

Otherwise, I am satisfied with the code, and after the urban type fix and Tim re-running the testcase, we are ready
for @jvgeiger to finish his review. Jim will likely remove many commented-out lines (including the comments about hard-coded values for vegetation and soil types, as well as debugging print statements). Then he can compare to Tim's updated testcase output with the latest code.

TimLahmers · 2024-08-23T22:29:22Z

@dmocko I just re-ran the test case, and it is in the same directory as before: /discover/nobackup/projects/ualbmap21/tlahmers/MMF_DemoCases_062023/LIS_MMF_CONUSvalid_RELSMCbug/OUTPUT.SIMGM.CONUS_RelSMC_Valid

The code change has been committed.

dmocko · 2024-09-27T14:32:03Z

Many thanks for @TimLahmers for re-running the testcase a couple times over the past couple weeks to address minor
issues with the testcase (but not with the code).

The latest testcases are here:
LDT: /discover/nobackup/tlahmers/SHARE/MMF_Testcases/LDT_run
LIS: /discover/nobackup/tlahmers/SHARE/MMF_Testcases/LIS_run

Note that this PR is only for LIS, so you only need to run/use the LIS testcase.

However, just for completeness, I successfully replicated both the LIS and the LDT testcase with identical results.

Further, I re-tested other Noah-MP-4.0.1 output variables using the new code but with SIMGM groundwater, and found
that no other variables are affected (again, identical results). So I confirm that this PR will not affect non-MMF output.

Finally, I did another complete code review, and believe that this PR is ready to merge - once @jvgeiger cleans up the
code comments to his satisfaction.

@jvgeiger - Please finish up and merge this PR once you have the time. Thanks!

dmocko · 2024-09-27T15:34:56Z

@jvgeiger - as long as you are cleaning up code, can you also remove the "NS" from this line before the PR is merged?

https://github.com/NASA-LIS/LISF/blob/master/lis/configs/lis.config.adoc?plain=1#L8306

Also @TimLahmers - what is the recommended number of "Halo size" that should be used? We should also specify that
halos must be turned on when using MMF option 5 (probably put it as a new sentence within lines 8293 to 8297 above).

TimLahmers · 2024-09-27T15:46:34Z

@dmocko @jvgeiger All of the tests we performed with MMF used a halo size of 3. Analysis from the earlier development stages (right after we fixed the bugs with the gather/scatter routines with halos) showed minimal round-off errors with that configuration compared to serial runs.

TimLahmers · 2025-12-17T17:07:16Z

@jvgeiger @dmocko I am replying to this thread on PR #1418 with an update. For the manuscript related to this feature, we added a change to the MMF code that improves the realism of channel exchanges and makes the model more stable (see recent commits). The LDT test case should not be affected; however, the LIS test case is being re-run and still resides in the directory (it is in the queue at the time of this message): /discover/nobackup/tlahmers/SHARE/MMF_Testcases/LIS_run

Per earlier questions, the standard halo size for MMF is 3

What are the final steps to complete this PR? Since this is a busy week, I can also wait until early 2026 to follow up on this matter.

Timothy M. Lahmers and others added 30 commits April 29, 2021 13:32

Adds Noah-MP precipitation timestep fix for cases where LIS dt is gre…

3d00edd

…ater than forcing dt

Merge branch 'master' of https://github.com/NASA-LIS/LISF

a1ae48b

Noah-MP MMF implementation, Shugong Wang

a0051ec

Merge branch 'master' of github:NASA-LIS/LISF

45485bc

Commit mmf_start

2e8a58a

SMCEQ maybe a state variable, rather than a parameter

de93094

Merge branch 'master' of github:TimLahmers/LISF into noahmp_mmf

a8fe289

Add PSI Fix lost in previous MMF development.

3eed614

Corrects indexing error in Noah-MP MMF Scheme.

0f02ec8

Fix restart modules for perfect MMF restarts; includes debug print st…

81f7922

…atements

Fix indexing error with no-data values; comment out debug statements.

13a7607

Add MMF variables Rech, Qrfs, Qsprings, Wtd to Noah-MP401 output.

4698bae

Corrects MMF sub-surface flow errors by removing bug with WTD and ZWT…

9edba8e

… updates.

Update comments in MMF branch.

948de67

Merge branch 'master' of github:NASA-LIS/LISF into noahmp_mmf

18bd181

Merge branch 'master' of github:NASA-LIS/LISF into noahmp_mmf

b3a9708

Prevent unphysical SMC values at initialization for MMF

59c5c1f

Fixes Bug with Flux Accumulation Variables in MMF GW Scheme

60c0f06

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

e31757c

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

efad6c2

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

0f423c1

Update specification of Noah-MP index variables for MMF.

14c7d95

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

94d3580

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

527e92c

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

96b24b7

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

d55d3fc

Fix MMF Initialization bug for parallel processor configurations.

6947538

Fix bug w/MMF scheme; enable LIS to finish when run with other Noah-M…

5424c4e

…P401 runoff modes.

Update indices for coldstart setup to support soil data other than ST…

a3a6114

…ATSGO.

Merge branch 'master' of github.com:NASA-LIS/LISF into noahmp_mmf

a02a3e3

jvgeiger requested a review from dmocko September 28, 2023 18:19

jvgeiger self-assigned this Oct 5, 2023

dmocko self-assigned this Jul 10, 2024

dmocko reviewed Jul 10, 2024

View reviewed changes

Timothy M. Lahmers and others added 3 commits July 31, 2024 13:00

Merge branch 'master' of https://github.com/NASA-LIS/LISF into noahmp…

7f9be93

…_mmf

Eliminate LIS Noah-MP v4.0.1 MMF Hard-Coded Soil and Veg layer-counts

074fdd2

Fix RelSMC output bug; solves problem of RelSMC being moved out of ma…

9f8a20c

…in loop w/MMF code addition

dmocko reviewed Aug 14, 2024

View reviewed changes

Set MMF Urban Classification to be same as LIS_rc%urbanclass

529f5d0

dmocko added the enhancement New feature or request label Nov 5, 2024

dmocko requested a review from jvgeiger November 5, 2024 17:58

jvgeiger added the NotReady label Mar 13, 2025

Timothy M. Lahmers and others added 2 commits December 3, 2025 17:27

Update LIS-MMF PEXP to limit channel exchange w/deep groundwater

66a7262

Set PEXP threshold to -20.0 m instead of LSM depth.

92b8f51

Conversation

TimLahmers commented Sep 22, 2023

Description

Testcase

Uh oh!

sudarsan3010 commented Jan 25, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmocko commented Jul 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmocko commented Aug 14, 2024

Uh oh!

TimLahmers commented Aug 23, 2024

Uh oh!

dmocko commented Sep 27, 2024

Uh oh!

dmocko commented Sep 27, 2024

Uh oh!

TimLahmers commented Sep 27, 2024

Uh oh!

TimLahmers commented Dec 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants