Skip to content

Commit 6a6f3b4

Browse files
Dan Allardbarugonman
Dan Allard
authored andcommitted
Addresses a11y labels issue #1609
1 parent ebfaa3a commit 6a6f3b4

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

src/components/TimelineItemList.svelte

+2
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,9 @@
149149
name="search"
150150
autocomplete="off"
151151
placeholder="Filter {typeName} types"
152+
aria-label="Filter {typeName} types"
152153
/>
154+
153155
<div class="filter-buttons">
154156
<button
155157
class="st-button secondary menu-button"

src/components/activity/ActivityDirectivesTablePanel.svelte

+10-4
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
ValueGetterParams,
1212
} from 'ag-grid-community';
1313
import { debounce } from 'lodash-es';
14+
import { get } from 'svelte/store';
1415
import { InvalidDate } from '../../constants/time';
1516
import { activityDirectivesMap, selectActivity, selectedActivityDirectiveId } from '../../stores/activities';
1617
import { activityErrorRollupsMap } from '../../stores/errors';
@@ -20,8 +21,10 @@
2021
import type { ActivityDirective } from '../../types/activity';
2122
import type { User } from '../../types/app';
2223
import type { AutoSizeColumns, ViewGridSection, ViewTable } from '../../types/view';
24+
import effects from '../../utilities/effects';
2325
import { filterEmpty } from '../../utilities/generic';
2426
import { formatDate, getUnixEpochTimeFromInterval } from '../../utilities/time';
27+
import { getTimeRangeAroundTime } from '../../utilities/timeline';
2528
import { tooltip } from '../../utilities/tooltip';
2629
import GridMenu from '../menus/GridMenu.svelte';
2730
import DataGrid from '../ui/DataGrid/DataGrid.svelte';
@@ -30,9 +33,6 @@
3033
import Panel from '../ui/Panel.svelte';
3134
import ActivityDirectivesTable from './ActivityDirectivesTable.svelte';
3235
import ActivityTableMenu from './ActivityTableMenu.svelte';
33-
import { get } from 'svelte/store';
34-
import { getTimeRangeAroundTime } from '../../utilities/timeline';
35-
import effects from '../../utilities/effects';
3636
3737
export let gridSection: ViewGridSection;
3838
export let user: User | null;
@@ -390,7 +390,13 @@
390390
<svelte:fragment slot="header">
391391
<GridMenu {gridSection} title="Activity Directives Table" />
392392
<div class="table-menu">
393-
<input type="search" bind:value={filterExpression} placeholder="Filter Activity Directives" class="st-input" />
393+
<input
394+
type="search"
395+
bind:value={filterExpression}
396+
placeholder="Filter Activity Directives"
397+
aria-label="Filter Activity Directives"
398+
class="st-input"
399+
/>
394400
<div class="size-actions">
395401
<button
396402
class="st-button secondary"

0 commit comments

Comments
 (0)