Skip to content

Check the PowerShell scripts for silly conversion errors, please #153

Open
@peSHIr

Description

@peSHIr

Had a quick look at https://github.com/NARKOZ/hacker-scripts/blob/master/powershell/fucking_coffee.psm1 but I have some issues with the conversion from the original language:

  • I don't think "if ($env:Username.Count > 0) { return }" does what you think it does. Quick heads-up: PowerShell has no return statement, or a ">" operator (which is written as "-gt" in PowerShell).

  • You don't call defined functions with the "Send-TelNetCommands($Writer, "sys brew", 24)" syntax. Correct syntax here would be "Send-TelNetCommands -writer $Writer -command 'sys brew' -WaitTime 24".

  • Calls to Send-TelNetCommands give wait times in seconds (from the description of the what the script should do elsewhere), but inside the function that parameter value is used as milliseoonds, given "Start-Sleep -Milliseconds $WaitTime" (which by the way does use correct PowerShell parameter syntax)

This is sort of silly, really... :-/

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions