Skip to content
This repository was archived by the owner on Sep 14, 2023. It is now read-only.

Commit bf58d9a

Browse files
committed
Delivery contracts improvments
1 parent 5d8af0f commit bf58d9a

File tree

4 files changed

+12
-21
lines changed

4 files changed

+12
-21
lines changed

Diff for: src/lib.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ mod tcp_serializer;
1212
pub use connection_attrs::{ConnectionAttributes, PacketProtVer};
1313

1414
pub use packet_versions::PacketVersions;
15-
pub use tcp_contracts::{MessageToDeliverTcpContract, TcpContract};
15+
pub use tcp_contracts::TcpContract;
1616
pub use tcp_serializer::MySbTcpSerializer;

Diff for: src/tcp_contracts.rs

+3-13
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
use my_service_bus_abstractions::MessageToPublish;
2-
use my_service_bus_shared::{
3-
queue::TopicQueueType, queue_with_intervals::QueueIndexRange, MessageId,
4-
};
1+
use my_service_bus_abstractions::{publisher::MessageToPublish, subscriber::MySbMessageToDeliver};
2+
use my_service_bus_shared::{queue::TopicQueueType, queue_with_intervals::QueueIndexRange};
53
use my_tcp_sockets::socket_reader::{ReadingTcpContractFail, SocketReader};
64

75
use crate::ConnectionAttributes;
@@ -14,14 +12,6 @@ pub type RequestId = i64;
1412

1513
pub type ConfirmationId = i64;
1614

17-
#[derive(Debug, Clone)]
18-
pub struct MessageToDeliverTcpContract {
19-
pub id: MessageId,
20-
pub attempt_no: i32,
21-
pub headers: Option<HashMap<String, String>>,
22-
pub content: Vec<u8>,
23-
}
24-
2515
#[derive(Debug, Clone)]
2616
pub enum TcpContract {
2717
Ping,
@@ -53,7 +43,7 @@ pub enum TcpContract {
5343
topic_id: String,
5444
queue_id: String,
5545
confirmation_id: i64,
56-
messages: Vec<MessageToDeliverTcpContract>,
46+
messages: Vec<MySbMessageToDeliver>,
5747
},
5848
NewMessagesConfirmation {
5949
topic_id: String,

Diff for: src/tcp_serializers/messages_to_deliver.rs

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1+
use my_service_bus_abstractions::subscriber::MySbMessageToDeliver;
12
use my_service_bus_shared::MySbMessageContent;
23
use my_tcp_sockets::socket_reader::{ReadingTcpContractFail, SocketReader};
34

4-
use crate::{MessageToDeliverTcpContract, PacketProtVer};
5+
use crate::PacketProtVer;
56

67
pub fn serialize(
78
dest: &mut Vec<u8>,
@@ -40,7 +41,7 @@ pub fn serialize_v3(dest: &mut Vec<u8>, msg: &MySbMessageContent, attempt_no: i3
4041
pub async fn deserialize<TSocketReader: SocketReader>(
4142
socket_reader: &mut TSocketReader,
4243
version: &PacketProtVer,
43-
) -> Result<MessageToDeliverTcpContract, ReadingTcpContractFail> {
44+
) -> Result<MySbMessageToDeliver, ReadingTcpContractFail> {
4445
if version.protocol_version < 3 {
4546
return deserialize_v2(socket_reader, version.packet_version).await;
4647
}
@@ -51,7 +52,7 @@ pub async fn deserialize<TSocketReader: SocketReader>(
5152
pub async fn deserialize_v2<TSocketReader: SocketReader>(
5253
socket_reader: &mut TSocketReader,
5354
packet_version: i32,
54-
) -> Result<MessageToDeliverTcpContract, ReadingTcpContractFail> {
55+
) -> Result<MySbMessageToDeliver, ReadingTcpContractFail> {
5556
let id = socket_reader.read_i64().await?;
5657

5758
let attempt_no = if packet_version == 1 {
@@ -62,7 +63,7 @@ pub async fn deserialize_v2<TSocketReader: SocketReader>(
6263

6364
let content = socket_reader.read_byte_array().await?;
6465

65-
let result = MessageToDeliverTcpContract {
66+
let result = MySbMessageToDeliver {
6667
id,
6768
headers: None,
6869
attempt_no,
@@ -74,7 +75,7 @@ pub async fn deserialize_v2<TSocketReader: SocketReader>(
7475

7576
pub async fn deserialize_v3<TSocketReader: SocketReader>(
7677
socket_reader: &mut TSocketReader,
77-
) -> Result<MessageToDeliverTcpContract, ReadingTcpContractFail> {
78+
) -> Result<MySbMessageToDeliver, ReadingTcpContractFail> {
7879
let id = socket_reader.read_i64().await?;
7980

8081
let attempt_no = socket_reader.read_i32().await?;
@@ -83,7 +84,7 @@ pub async fn deserialize_v3<TSocketReader: SocketReader>(
8384

8485
let content = socket_reader.read_byte_array().await?;
8586

86-
let result = MessageToDeliverTcpContract {
87+
let result = MySbMessageToDeliver {
8788
id,
8889
headers,
8990
attempt_no,

Diff for: src/tcp_serializers/messages_to_publish.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use my_service_bus_abstractions::MessageToPublish;
1+
use my_service_bus_abstractions::publisher::MessageToPublish;
22

33
pub fn serialize(data: &mut Vec<u8>, v: &Vec<MessageToPublish>, protocol_version: i32) {
44
if protocol_version < 3 {

0 commit comments

Comments
 (0)