Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code in CSSList #994

Open
5 of 9 tasks
oliverklee opened this issue Feb 25, 2025 · 0 comments
Open
5 of 9 tasks

Refactor code in CSSList #994

oliverklee opened this issue Feb 25, 2025 · 0 comments
Assignees
@oliverklee
Milestone
8.9.0: Deprecatio...

Comments

@oliverklee
Copy link
Contributor

oliverklee commented Feb 25, 2025 •
edited
Loading

The goal is to get rid of redundant code and to reduce functions that have return parameters (which are both hard to understand as well as hard analyze with PHPStan).

  • move getAllDeclarationBlocks from Document to the parent class CSSBlockList
  • refactor getAllDeclarationBlocks
  • replace usages of CSSBlockList::allDeclarationBlocks with calls to ::getAllDeclarationBlocks and drop allDeclarationBlocks
  • move getAllRuleSets from Document to the parent class CSSBlockList
  • refactor getAllRuleSets
  • replace usages of CSSBlockList::allRuleSets with calls to ::getAllRuleSets and drop allRuleSets
  • move getAllValues from Document to the parent class CSSBlockList
  • refactor getAllValues
  • replace usages of CSSBlockList::allValues with calls to ::getAllValues and drop allValues
@oliverklee oliverklee self-assigned this Feb 25, 2025
oliverklee added a commit that referenced this issue Feb 25, 2025
@oliverklee
[CLEANUP] Refactor Document::getAllDeclarationBlocks()
fec6092 
This is a pre-patch to moving `getAllDeclarationBlocks()` up
to `CSSBlockList`.

Part of #994.
@oliverklee oliverklee mentioned this issue Feb 25, 2025
Merged
oliverklee added a commit that referenced this issue Feb 25, 2025
@oliverklee
[CLEANUP] Refactor Document::getAllDeclarationBlocks()
9384d39 
This is a pre-patch to moving `getAllDeclarationBlocks()` up
to `CSSBlockList`.

Part of #994.
oliverklee added a commit that referenced this issue Feb 25, 2025
@oliverklee
[TASK] Move getAllDeclarationBlocks up to CSSBlockList
013250c 
Move this method up without any changes to the method or its
callers.

We'll clean this up in later changes.

Part of #994.
@oliverklee oliverklee mentioned this issue Feb 25, 2025
Merged
oliverklee added a commit that referenced this issue Feb 25, 2025
@oliverklee
[TASK] Move up getAllDeclarationBlocks to CSSBlockList
3f7a428 
Move this method up without any changes to the method or its
callers.

We'll clean this up in later changes.

Part of #994.
oliverklee added a commit that referenced this issue Feb 26, 2025
@oliverklee
[TASK] Move up getAllDeclarationBlocks to CSSBlockList
ae0d883 
Move this method up without any changes to the method or its
callers.

We'll clean this up in later changes.

Part of #994.
oliverklee added a commit that referenced this issue Feb 26, 2025
@oliverklee
[CLEANUP] Refactor ::getAllDeclarationBlocks()
1529fd3 
Part of #994.
oliverklee added a commit that referenced this issue Feb 26, 2025
@oliverklee
[TASK] Move up getAllDeclarationBlocks to CSSBlockList
2255abc 
Move this method up without any changes to the method or its
callers.

We'll clean this up in later changes.

Part of #994.
JakeQZ pushed a commit that referenced this issue Feb 26, 2025
@oliverklee
[TASK] Move up getAllDeclarationBlocks to CSSBlockList (#996)
a1f9f58 
Move this method up without any changes to the method or its
callers.

We'll clean this up in later changes.

Part of #994.
oliverklee added a commit that referenced this issue Feb 26, 2025
@oliverklee
[CLEANUP] Refactor ::getAllDeclarationBlocks()
5709945 
Part of #994.
oliverklee added a commit that referenced this issue Feb 27, 2025
@oliverklee
[CLEANUP] Refactor ::getAllDeclarationBlocks()
83ec454 
Part of #994.
JakeQZ pushed a commit that referenced this issue Feb 27, 2025
@oliverklee
[CLEANUP] Refactor ::getAllDeclarationBlocks() (#990)
e1f8bd3 
Part of #994.
oliverklee added a commit that referenced this issue Mar 1, 2025
@oliverklee
[TASK] Move up getAllRuleSets to CSSBlockList
f72bc69 
Move this method up without any changes to the method or its callers.

We'll clean this up in later changes.

Part of #994.
@oliverklee oliverklee mentioned this issue Mar 1, 2025
Merged
JakeQZ pushed a commit that referenced this issue Mar 2, 2025
@oliverklee
[TASK] Move up getAllRuleSets to CSSBlockList (#1047)
f912e71 
Move this method up without any changes to the method or its callers.

We'll clean this up in later changes.

Part of #994.
oliverklee added a commit that referenced this issue Mar 2, 2025
@oliverklee
[CLEANUP] Refactor CSSBlockList::getAllRuleSets()
82667e2 
Also remove the now-unused method `allRuleSets()`.

Part of #994.
@oliverklee oliverklee mentioned this issue Mar 2, 2025
Merged
JakeQZ pushed a commit that referenced this issue Mar 2, 2025
@oliverklee
[CLEANUP] Refactor CSSBlockList::getAllRuleSets() (#1050)
54ca442 
Also remove the now-unused method `allRuleSets()`.

Part of #994.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

No branches or pull requests
1 participant
@oliverklee