Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rebasing guidelines to CONTRIBUTING.md #1215

Open
JakeQZ opened this issue Mar 25, 2025 · 1 comment · Fixed by #1220
Open

Add rebasing guidelines to CONTRIBUTING.md #1215

JakeQZ opened this issue Mar 25, 2025 · 1 comment · Fixed by #1220
Labels
developer-specific Issues that only affect maintainers, contributors, and people submitting PRs documentation
Milestone
9.0.0: Drop suppo...

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Mar 25, 2025

These can be copied from https://github.com/MyIntervals/emogrifier/blob/main/CONTRIBUTING.md, with any necessary name changes to match this project rather than that.
@JakeQZ JakeQZ added developer-specific Issues that only affect maintainers, contributors, and people submitting PRs documentation labels Mar 25, 2025
@oliverklee oliverklee changed the title Add rebasiing guidelines to CONTRIBUTING.md Add rebasing guidelines to CONTRIBUTING.md Mar 25, 2025
JakeQZ added a commit that referenced this issue Mar 26, 2025
@JakeQZ
[TASK] Add rebasing guidelines to CONTRIBUTING.md
ea227a9 
This section is copied directly from the sister project, Emogrifier.

Resolves #1215.
JakeQZ added a commit that referenced this issue Mar 26, 2025
@JakeQZ
[TASK] Add rebasing guidelines to CONTRIBUTING.md
a5a498b 
This section is copied directly from the sister project, Emogrifier.

Resolves #1215.
@JakeQZ JakeQZ mentioned this issue Mar 26, 2025
Merged
@JakeQZ JakeQZ reopened this Mar 28, 2025
@JakeQZ
Copy link
Contributor Author

JakeQZ commented Mar 28, 2025

This needs improving as per #1220 (review).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer-specific Issues that only affect maintainers, contributors, and people submitting PRs documentation
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[TASK] Add rebasing guidelines to CONTRIBUTING.md MyIntervals/PHP-CSS-Parser
1 participant
@JakeQZ