Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Rule.rule to Rule.propertyName #1011

Open
oliverklee opened this issue Feb 27, 2025 · 2 comments
Open

Rename Rule.rule to Rule.propertyName #1011

oliverklee opened this issue Feb 27, 2025 · 2 comments

Comments

@oliverklee
Copy link
Contributor

As suggested in a review: #1004 (comment)

https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/CSS_Declaration

@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 27, 2025

It's already private, so we can do this without any deprecation issues.

@JakeQZ
Copy link
Contributor

JakeQZ commented Feb 27, 2025

OTOH, there are the getRule and setRule methods, which would need corresponding getPropertyName and setPropertyName replacements, and a deprecation notice for the originals saying to use the replacements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants