ASM Help

[Paralaxus]

Hi.

I basically forked MyEssentials, MyPermissions and MyTown into a single mod.
I made it more "Factions" oriented, with raiding modifications & aesthetic improvements.

I'm planning on keeping it updated and releasing soon, but i have a tiny problem:

It seems i messed something up in the ASM code i copied, which won't let me build.

Was wondering if you could check out what i'm doing wrong:

Empires-Mod Repo

Build Failure: (Pointing to ASM Code):

MC Crash Report when i break a sign:

// There are four lights!

Time: 5/12/18 3:32 PM
Description: Ticking memory connection

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.NoSuchFieldException: Empires
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataValue(SignClassTransformer.java:102)
	at EmpiresMod.entities.Managers.SignManager.loadSign(SignManager.java:32)
	at EmpiresMod.entities.Managers.SignManager.onPlayerBreaksBlock(SignManager.java:63)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_17_SignManager_onPlayerBreaksBlock_BreakEvent.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:469)
	at net.minecraft.server.management.ItemInWorldManager.tryHarvestBlock(ItemInWorldManager.java:285)
	at net.minecraft.server.management.ItemInWorldManager.onBlockClicked(ItemInWorldManager.java:168)
	at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:523)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:61)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:94)
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)
	at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)
Caused by: java.lang.RuntimeException: java.lang.NoSuchFieldException: Empires
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataField(SignClassTransformer.java:81)
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataValue(SignClassTransformer.java:100)
	... 18 more
Caused by: java.lang.NoSuchFieldException: Empires
	at java.lang.Class.getField(Class.java:1703)
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataField(SignClassTransformer.java:78)
	... 19 more


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Stacktrace:
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataValue(SignClassTransformer.java:102)
	at EmpiresMod.entities.Managers.SignManager.loadSign(SignManager.java:32)
	at EmpiresMod.entities.Managers.SignManager.onPlayerBreaksBlock(SignManager.java:63)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_17_SignManager_onPlayerBreaksBlock_BreakEvent.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:469)
	at net.minecraft.server.management.ItemInWorldManager.tryHarvestBlock(ItemInWorldManager.java:285)
	at net.minecraft.server.management.ItemInWorldManager.onBlockClicked(ItemInWorldManager.java:168)
	at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:523)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:61)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:94)
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)

-- Ticking connection --
Details:
	Connection: net.minecraft.network.NetworkManager@256560f7
Stacktrace:
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)
	at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

-- System Details --
Details:
	Minecraft Version: 1.7.10
	Operating System: Mac OS X (x86_64) version 10.11.3
	Java Version: 1.8.0_73, Oracle Corporation
	Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
	Memory: 848649544 bytes (809 MB) / 1038876672 bytes (990 MB) up to 1038876672 bytes (990 MB)
	JVM Flags: 3 total; -Xincgc -Xmx1024M -Xms1024M
	AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
	IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
	FML: MCP v9.05 FML v7.10.99.99 Minecraft Forge 10.13.4.1614 4 mods loaded, 4 mods active
	States: 'U' = Unloaded 'L' = Loaded 'C' = Constructed 'H' = Pre-initialized 'I' = Initialized 'J' = Post-initialized 'A' = Available 'D' = Disabled 'E' = Errored
	UCHIJAAAA	mcp{9.05} [Minecraft Coder Pack] (minecraft.jar) 
	UCHIJAAAA	FML{7.10.99.99} [Forge Mod Loader] (forgeSrc-1.7.10-10.13.4.1614-1.7.10.jar) 
	UCHIJAAAA	Forge{10.13.4.1614} [Minecraft Forge] (forgeSrc-1.7.10-10.13.4.1614-1.7.10.jar) 
	UCHIJAAAA	EmpiresMod{1.0.0} [EmpiresMod] (bin) 
	GL info: ~~ERROR~~ RuntimeException: No OpenGL context found in the current thread.
	Empires|Datasource: ~~ERROR~~ NullPointerException: null
	Profiler Position: N/A (disabled)
	Vec3 Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
	Player Count: 1 / 8; [EntityPlayerMP['Player767'/23, l='New World', x=600.67, y=56.00, z=-1549.14]]
	Type: Integrated Server (map_client.txt)
	Is Modded: Definitely; Client brand changed to 'fml,forge'

Build Error:

                        super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Transformers/AE2NetworkToolTransformer",
                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/AE2PlaceTransformer.java:61: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/AE2PartPlaceEvent", "fireEvent",
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFarmlandTransformer.java:71: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/BlockTrampleEvent", "fireEvent",
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:41: error: method does not override or implement a method from a supertype
                @Override
                ^
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:47: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                        super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ModifyBlockEvent",
                                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:52: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                        super.visitMethodInsn(opcode, owner, name, desc, itf);
                                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:57: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                        super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ModifyBlockEvent",
                                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:65: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                        super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ModifyBlockEvent",
                                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:70: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                        super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ModifyBlockEvent",
                                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockFireTransformer.java:76: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                        super.visitMethodInsn(opcode, owner, name, desc, itf);
                             ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/BlockTaintFibersTransformer.java:37: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ModifyBiomeEvent", "checkBiome",
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityFireballTransformer.java:50: error: method does not override or implement a method from a supertype
                @Override
                ^
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityFireballTransformer.java:55: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ProjectileImpactEvent", "fireEvent",
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityFireballTransformer.java:62: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(opcode, owner, name, desc, itf);
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityFireballTransformer.java:66: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(opcode, owner, name, desc, itf);
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityThrowableTransformer.java:50: error: method does not override or implement a method from a supertype
                @Override
                ^
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityThrowableTransformer.java:55: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Events/ProjectileImpactEvent", "fireEvent",
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityThrowableTransformer.java:62: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(opcode, owner, name, desc, itf);
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/EntityThrowableTransformer.java:66: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(opcode, owner, name, desc, itf);
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
/Users/Andrew/Desktop/Eclipse/WorkSpace/Minecraft/Mods/1.7.10/Empires-Mod May 7 2018/Empires-Mod/build/sources/java/EmpiresMod/Transformers/SignClassTransformer.java:213: error: method visitMethodInsn in class MethodVisitor cannot be applied to given types;
                                super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Transformers/SignClassTransformer", localMethodName,
                                     ^
  required: int,String,String,String
  found: int,String,String,String,boolean
  reason: actual and formal argument lists differ in length
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
20 errors
:compileJava FAILED
:compileJava (Thread[main,5,main]) completed. Took 1 mins 4.278 secs.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --debug option to get more log output.

BUILD FAILED

Total time: 2 mins 1.774 secs
Stopped 0 compiler daemon(s).```

Was wondering if you could help me out here.
Thanks!

~Andrew

[jgoett154]

Hello,

Just as preliminary skim through your source the issue might be with the at symbol in the FIELD_NAME and/or TAG_ROOT. Removing that may fix it. I am not super proficient in the ASM portion of the mods, it was implemented by someone else. I will continue to skim through and see if there is anything else I am missing.

[Paralaxus]

Hey! Thanks for the reply!!
It's not the @ symbol, i put that there recently thinking it might fix the problem,
(Using getFields() method returned a "@" and a unique serial, thought I was missing the symbol)

I thought it could be directory issues like:
line 25 in EmpiresMod/Transformers/SignClassTransformer:

super.visitMethodInsn(Opcodes.INVOKESTATIC, "EmpiresMod/Transformers/SignClassTransformer", localMethodName,

However changing these did not correct the issue, and i'm stuck scratching my head.
I'd really appreciate it if you found a little time to go through my source proficiently, and help me identify the problematic code.

I too myself have no knowledge of ASM and prefer going around it.

Thank you!
~Andrew

[Paralaxus]

Any thoughts?

[jgoett154]

Not currently, everything looks like it should be fine when I was comparing the two. I will continue looking, I have a couple thoughts on what might be occurring but I need to try a couple things after my work.

On Tue, May 15, 2018, 4:48 AM Andrew ***@***.***> wrote: Any thoughts? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#520 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADD015ONi5tvk13zOHcKi_Wwk-3kkNh1ks5typZ7gaJpZM4T8k_1> .

-- ~ Joe Goett

[jgoett154]

Having reviewed the Javadoc for OW ASM I believe what is occurring is the version being used is 4.0 which doesn't like the visitMethodInsn function. This seems to stem from the version of ReflectASM being used. I believe bumping ReflectASMs version to at least 1.11.0 should fix it as it will use 5.0.3 of the ASM lib which includes the correct visitMethodInsn. I am unsure why it is a problem in the first place as I would have assumed it would use the latest.-- ~ Joe Goett

[Paralaxus]

Hey,

Yeah i updated it to the latest version 1.11.5, but it keeps crashing:

java.lang.RuntimeException: java.lang.RuntimeException: java.lang.NoSuchFieldException: empiresMod
	at EmpiresMod.Transformers.SignClassTransformer.getEmpiresDataValue(SignClassTransformer.java:104)
	at EmpiresMod.entities.Managers.SignManager.loadSign(SignManager.java:32)
	at EmpiresMod.entities.Managers.SignManager.onPlayerBreaksBlock(SignManager.java:63)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler_17_SignManager_onPlayerBreaksBlock_BreakEvent.invoke(.dynamic)
	at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54)
	at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140)
	at net.minecraftforge.common.ForgeHooks.onBlockBreakEvent(ForgeHooks.java:469)
	at net.minecraft.server.management.ItemInWorldManager.tryHarvestBlock(ItemInWorldManager.java:285)
	at net.minecraft.server.management.ItemInWorldManager.onBlockClicked(ItemInWorldManager.java:168)
	at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:523)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:61)
	at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:94)
	at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:241)
	at net.minecraft.network.NetworkSystem.networkTick(NetworkSystem.java:182)
	at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:726)
	at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:614)
	at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:118)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:485)
	at net.minecraft.server.MinecraftServer$2.run(MinecraftServer.java:752)

[jgoett154]

Interesting, I will try to clone the repo and poke at it once I am home from work in a few hours. There doesn't appear to be anything obvious with why it's not working at this point.-- ~ Joe Goett

[Paralaxus]

Yeah i've been scratching my head at this for a couple days now.
Sure, clone it and see whenever you can, i'd appreciate it a lot.

[Paralaxus]

Any luck?

[Paralaxus]

? @jgoett154

[jgoett154]

Sorry, I have not gotten a change to yet. I will be able to sometime tomorrow though.

On Fri, May 18, 2018 at 8:24 PM Andrew ***@***.***> wrote: ? @jgoett154 <https://github.com/jgoett154> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#520 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADD013JsAe5tG8BQ69r6KvfPFbRewjSyks5tz2ZAgaJpZM4T8k_1> .

-- ~ Joe Goett

[Paralaxus]

Alright,
I can't seem to figure it out, had a couple others take a look.
It shouldn't be causing problems.

[jgoett154]

I have finally gotten a chance to take a look at it (sorry for the wait). I can't get it to crash when placing or breaking a sign so far. I also have been able to build it several times so far with a completely fresh run of setupDevEnvironment. I am honestly unsure as to the issues that is occuring with the logs you have provided. It shouldn't be causing any problems as you said.

[Paralaxus]

That's really weird.
Any ideas why it couldn't build or work for me? I'm using eclipse.
Also what command did you use to build it? i use ./gradlew build -i

[jgoett154]

Im currently using VSCode for the editor (its what I have and I know works atm) I was using Intellij Idea when I was actively working on MT2. I was using gradle build. Just attempted with ./gradlew build and ./gradlew build -i and both worked 0 issues. Perhaps run a ./gradlew clean and try building again? Perhaps it's an issue with previously cached data that gradle is complaining about.