Fix linting

Author: eyeseast

.isort.cfg

@@ -3,7 +3,6 @@ line_length=88
 force_to_top=
 skip=
 skip_glob=
-not_skip=__init__.py
 known_future_library=__future__
 known_first_party=documentcloud
 indent='    '

.pylintrc

@@ -4,6 +4,3 @@ good-names=i,x1,x2,y1,y2,id
 
 [MESSAGES CONTROL]
 disable=missing-docstring,too-many-ancestors,too-few-public-methods,no-else-return,no-member,attribute-defined-outside-init,similarities,import-outside-toplevel,cyclic-import,no-member,no-else-raise,too-many-instance-attributes,too-many-arguments,ungrouped-imports,useless-object-inheritance,no-else-continue
-
-[DESIGN]
-max-positional-arguments=10

Makefile

@@ -41,10 +41,10 @@ coverage:
 check:
 	pylint documentcloud
 	black documentcloud
-	isort -rc documentcloud
+	isort documentcloud
 	pylint tests
 	black tests
-	isort -rc tests
+	isort tests
 
 # release a new version of the package to PyPI
 ship:

documentcloud/addon.py

@@ -195,7 +195,7 @@ def store_run_data(self, data):
         "Store persistent data for this run"
         if not self.id:
             print("Run ID not set. Try again later or check if something went wrong.")
-            return
+            return None
 
         if not isinstance(data, dict):
             raise TypeError("Invalid data")

documentcloud/documents.py

@@ -24,8 +24,10 @@
 from .users import User
 
 try:
+    # Standard Library
     from urllib.parse import urlparse
 except ImportError:
+    # Third Party
     from urlparse import urlparse
 
 logger = logging.getLogger("documentcloud")

documentcloud/exceptions.py

@@ -2,11 +2,14 @@
 Custom exceptions for python-documentcloud
 """
 
+# Third Party
 # pylint: disable=unused-import
 # Import exceptions from python-squarelet
-from squarelet.exceptions import SquareletError as DocumentCloudError
-from squarelet.exceptions import DuplicateObjectError
-from squarelet.exceptions import CredentialsFailedError
-from squarelet.exceptions import APIError
-from squarelet.exceptions import DoesNotExistError
-from squarelet.exceptions import MultipleObjectsReturnedError
+from squarelet.exceptions import (
+    APIError,
+    CredentialsFailedError,
+    DoesNotExistError,
+    DuplicateObjectError,
+    MultipleObjectsReturnedError,
+    SquareletError as DocumentCloudError,
+)

tests/test_addon.py

@@ -7,6 +7,8 @@
 # DocumentCloud
 from documentcloud.addon import AddOn
 
+# pylint: disable=redefined-outer-name
+
 
 @pytest.fixture
 def addon():