Try to resolve pylint error

Author: duckduckgrayduck

documentcloud/addons/models.py

@@ -189,6 +189,7 @@ def dispatch(self, uuid, user, documents, query, parameters, event_id):
             f"{self.api_url}/dispatches",
             headers=self.api_headers,
             json={"event_type": self.name, "client_payload": payload},
+            timeout=10
         )
         resp.raise_for_status()
 
@@ -197,6 +198,7 @@ def update_config(self):
         resp = requests.get(
             f"{self.api_url}/contents/config.yaml",
             headers={**self.api_headers, "Accept": "application/vnd.github.v3.raw"},
+            timeout=10
         )
         if resp.status_code == 404:
             self.error = True
@@ -380,7 +382,7 @@ def find_run_id(self):
         url = f"{self.addon.api_url}/actions/runs?created=%3E{date_filter}"
         while url is not None:
             logger.info("[FIND RUN ID] get %s", url)
-            resp = requests.get(url, headers=self.addon.api_headers)
+            resp = requests.get(url, headers=self.addon.api_headers, timeout=10)
             resp.raise_for_status()
             url = resp.links.get("next", {}).get("url")
             resp_json = resp.json()
@@ -403,7 +405,11 @@ def find_run_id(self):
                     else:
                         continue
 
-                resp = requests.get(jobs_url, headers=self.addon.api_headers)
+                resp = requests.get(
+                    jobs_url, 
+                    headers=self.addon.api_headers,
+                    timeout=10
+                )
                 resp.raise_for_status()
 
                 jobs = resp.json()["jobs"]
@@ -435,6 +441,7 @@ def set_status(self):
         resp = requests.get(
             f"{self.addon.api_url}/actions/runs/{self.run_id}",
             headers=self.addon.api_headers,
+            timeout=10
         )
         if resp.status_code != 200:
             logger.info(
@@ -449,7 +456,9 @@ def set_status(self):
                 # if we failed, check the job status to check for 'cancelled'
                 # which means it timed out
                 resp = requests.get(
-                    resp.json()["jobs_url"], headers=self.addon.api_headers
+                    resp.json()["jobs_url"], 
+                    headers=self.addon.api_headers,
+                    timeout=10
                 )
                 if resp.status_code == 200 and len(resp.json()["jobs"]) > 0:
                     status = resp.json()["jobs"][0]["conclusion"]
@@ -510,6 +519,7 @@ def cancel(self):
         resp = requests.post(
             f"{self.addon.api_url}/actions/runs/{self.run_id}/cancel",
             headers=self.addon.api_headers,
+            timeout=10
         )
         if resp.status_code == 202:
             return "succeed"
@@ -718,6 +728,7 @@ def token(self):
                         "https://api.github.com/app/installations/"
                         f"{self.iid}/access_tokens",
                         headers=headers,
+                        timeout=10
                     )
                     resp = resp.json()
                     token = resp["token"]

documentcloud/addons/views.py

@@ -1004,6 +1004,7 @@ def verify_signature(request):
         uid=data["sender"]["id"], defaults={"name": data["sender"]["login"]}
     )
     if data.get("action") in ["added", "created"]:
+        repos = []
         logger.info("[GITHUB WEBHOOK] %s", data["action"])
         installation, _created = GitHubInstallation.objects.get_or_create(
             iid=data["installation"]["id"],
@@ -1022,11 +1023,11 @@ def verify_signature(request):
             with transaction.atomic():
                 AddOn.objects.update_or_create(
                     repository=repo["full_name"],
-                    defaults=dict(
-                        github_account=acct,
-                        github_installation=installation,
-                        removed=False,
-                    ),
+                    defaults={
+                        "github_account": acct,
+                        "github_installation": installation,
+                        "removed": False,
+                    },
                 )
                 transaction.on_commit(
                     lambda r=repo: update_config.delay(r["full_name"])
@@ -1165,7 +1166,7 @@ def get(self, request, *args, **kwargs):
             url += "/"
         url += kwargs.get("path", "")
 
-        response = requests.get(url)
+        response = requests.get(url, timeout=10)
         return HttpResponse(
             content=response.content,
             status=response.status_code,

documentcloud/common/environment/aws/processing_token.py

@@ -17,7 +17,7 @@ def authenticate_token(*args, **kwargs):
         headers = event["headers"]
 
         if headers.get(AUTHORIZATION) != f"processing-token {PROCESSING_TOKEN}":
-            raise Exception("Authentication Failed.")
+            raise PermissionError("Authentication Failed.")
 
         # If all passes, auth succeeded
         return func(*args, **kwargs)

documentcloud/common/environment/gcp/httpsub.py

@@ -1,4 +1,4 @@
-# pylint: disable=unused-import
+# pylint: disable=unused-import, import-error
 
 # Third Party
 from common import session as httpsub

documentcloud/documents/models/document.py

@@ -744,6 +744,7 @@ def invalidate_cache(self):
                     "X-Auth-Email": cloudflare_email,
                     "X-Auth-Key": cloudflare_key,
                 },
+                timeout=10
             )
 
     def index_on_commit(self, **kwargs):

documentcloud/documents/search.py

@@ -132,6 +132,7 @@ def search(user, query_params):
         "hl.weightMatches": settings.SOLR_HL_WEIGHT_MATCHES,
         **page_query_data,
     }
+    original_text_query = text_query
     if (
         settings.SOLR_QUERY_NOTES
         and user.is_authenticated
@@ -140,7 +141,6 @@ def search(user, query_params):
     ):
         # turn note queries on for all pro users
         # *:* returns all documents, do not enable note queries
-        original_text_query = text_query
         text_query = _add_note_query(text_query, user)
         kwargs["uf"] = "* _query_ -projects_edit_access"
         query_notes = True