Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configurable file/directory bindings #9

Open
vmenger opened this issue Jan 7, 2021 · 1 comment
Open

Make configurable file/directory bindings #9

vmenger opened this issue Jan 7, 2021 · 1 comment
Labels
⚙ config Issues and requests related to user configuration ✨ enhancement New feature or request 🔜 high priority If you're looking for something to work on - consider this first

Comments

@vmenger
Copy link
Contributor

vmenger commented Jan 7, 2021

It would be nice to be able to mount local directories to the docker image so that files can be used in the notebook.

I could see it work:

  • As a parameter to the docker install command e.g. dockernell install image_1 --bind c:/data /opt/data/ ~/.aws ~/.aws
  • In an optional config file stored in ~/.dockernel (e.g. a json file with {"name": "image_1", "bindings" : {"C:/data": "/opt/data/", "~/.aws": "~/.aws"}})

Second one would be especially useful for mounting config files like .aws or pip.ini in some docker kernel. Nice addition moreover would be to add the option to mount to all dockernel installs.

@MrMino
Copy link
Owner

MrMino commented Mar 21, 2021

Both points seem to be great ideas. I'll probably do this in the upcoming weeks, but if you'd like to do it, notify me - PRs welcome!

@MrMino MrMino added the ✨ enhancement New feature or request label Mar 21, 2021
@MrMino MrMino added ⚙ config Issues and requests related to user configuration 🔜 high priority If you're looking for something to work on - consider this first labels Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙ config Issues and requests related to user configuration ✨ enhancement New feature or request 🔜 high priority If you're looking for something to work on - consider this first
Projects
None yet
Development

No branches or pull requests

2 participants