Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HarvestNodeConnections crashing the game #275

Open
glitchysparx opened this issue Feb 28, 2025 · 12 comments
Open

HarvestNodeConnections crashing the game #275

glitchysparx opened this issue Feb 28, 2025 · 12 comments

Comments

@glitchysparx
Copy link

glitchysparx commented Feb 28, 2025

I have a lot of problems with your plugin. Almost each time I open the asset (one same asset not all assets) I have a crash in the UE delegates implementation. However, if I will not open the asset in the Editor but in the Game, it will crash in the function HarvestNodeConnections:

Image

because GetGraphNode() is not valid in the Node.

I press Validate and Save button in the Asset Editor but it doesn't help for next time I startup the project.

This asset is a root asset in the flow sequence:

Image

@MaksymKapelianovych
Copy link
Contributor

Can you provide more info about the problematic node? Which node type is this and how is it set up?

@glitchysparx
Copy link
Author

glitchysparx commented Feb 28, 2025

@MaksymKapelianovych sure.

Image
this root asset is a flow asset consists of subgraphs mainly.

Image

but we don't even implement the FlowNode_Start. It's not our node

@glitchysparx
Copy link
Author

@MaksymKapelianovych seems like verifying the validation of the GetGraphNode() would fix the crash but I don't know what logic do I need to implement in such use case (when it not valid) to not get another unlimited amount of new errors

@MaksymKapelianovych
Copy link
Contributor

Okay, what do you mean by "open asset in the Game"?

@glitchysparx
Copy link
Author

glitchysparx commented Feb 28, 2025

@MaksymKapelianovych "open asset in the Game" == "start the flow sequence". In such case I get that error above

@glitchysparx
Copy link
Author

@MaksymKapelianovych when I open this same asset in the Editor I get another error:

Image

@glitchysparx
Copy link
Author

glitchysparx commented Feb 28, 2025

@MaksymKapelianovych so 2 different errors with the same asset in different running modes (Editor and Game). I would fix the asset or add some functionality, I just don't understand the nature of this error

@MaksymKapelianovych
Copy link
Contributor

Are you talking about this? 🙂
Image

@glitchysparx
Copy link
Author

glitchysparx commented Feb 28, 2025

@MaksymKapelianovych nope. About PIE.

Image

@MaksymKapelianovych
Copy link
Contributor

It seems you have modified or outdated version of Flow, your line numbers on images do not match with repo

@MaksymKapelianovych
Copy link
Contributor

Please update plugin to the last version and if this issue will persist, ping me, I will be able to help then.

@MothDoctor
Copy link
Contributor

Hey, it seems this asset either has a fully created node (Flow Node itself added, but no Graph Node representation for some reason) or not-fully removed one. Hard to tell what caused it, as I haven't encountered such issues for years.

This shouldn't ever happen. I would recommend you temporarily add non-crashing null checks. Open asset, and copy-paste its graph to another asset. Remove the old asset, revert these null checks, and check if everything works fine. This might be the best approach as it's impossible to guess what might cause it.
Especially since a lot of graph processing code changed lately. It might be counter-productive to look into that further if an issue occurs only in a single asset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants