diff --git a/.github/workflows/i18n_check.yml b/.github/workflows/i18n_check.yml index cc82435..116e8c4 100644 --- a/.github/workflows/i18n_check.yml +++ b/.github/workflows/i18n_check.yml @@ -57,15 +57,15 @@ jobs: # Check for specific issues MISSING=$(grep -E "^\s+\d+/\d+ translated, [1-9]\d* missing" translation-report.txt | wc -l || echo "0") - UNTRANSLATED=$(grep -E "^\s+\d+/\d+ translated, \d+ missing, [1-9]\d* untranslated" translation-report.txt | wc -l || echo "0") + UNTRANSLATED_LOCALES=$(grep -E "^\s+\d+/\d+ translated, \d+ missing, [1-9]\d* untranslated" translation-report.txt | wc -l || echo "0") ZOMBIES=$(grep -E "^[a-z-]+: \d+ zombie key" translation-report.txt | wc -l || echo "0") echo "missing_count=$MISSING" >> $GITHUB_OUTPUT - echo "untranslated_count=$UNTRANSLATED" >> $GITHUB_OUTPUT + echo "untranslated_count=$UNTRANSLATED_LOCALES" >> $GITHUB_OUTPUT echo "zombie_count=$ZOMBIES" >> $GITHUB_OUTPUT # Determine if there are issues - if [ "$AVG" -eq 100 ] && [ "$MISSING" -eq 0 ] && [ "$ZOMBIES" -eq 0 ]; then + if [ "$AVG" -eq 100 ] && [ "$MISSING" -eq 0 ] && [ "$UNTRANSLATED_LOCALES" -eq 0 ] && [ "$ZOMBIES" -eq 0 ]; then echo "has_issues=false" >> $GITHUB_OUTPUT else echo "has_issues=true" >> $GITHUB_OUTPUT @@ -79,6 +79,7 @@ jobs: HAS_ISSUES="${{ steps.check_status.outputs.has_issues }}" EN_CHANGES="${{ steps.check_changes.outputs.changes }}" MISSING="${{ steps.check_status.outputs.missing_count }}" + UNTRANSLATED_LOCALES="${{ steps.check_status.outputs.untranslated_count }}" ZOMBIES="${{ steps.check_status.outputs.zombie_count }}" # Start building comment @@ -123,6 +124,9 @@ jobs: if [ "$MISSING" -gt 0 ]; then echo "- ⚠️ **$MISSING** missing translation(s)" >> comment.md fi + if [ "$UNTRANSLATED_LOCALES" -gt 0 ]; then + echo "- ⚠️ **$UNTRANSLATED_LOCALES** locale(s) contain untranslated string(s)" >> comment.md + fi if [ "$ZOMBIES" -gt 0 ]; then echo "- 🧟 **$ZOMBIES** zombie key(s) found" >> comment.md fi @@ -142,9 +146,12 @@ jobs: # Action items echo "### 🔧 Action Items" >> comment.md echo "" >> comment.md - if [ "$AVG" -lt 100 ]; then + if [ "$MISSING" -gt 0 ]; then echo "- Complete missing translations for all locales" >> comment.md fi + if [ "$UNTRANSLATED_LOCALES" -gt 0 ]; then + echo "- Translate untranslated strings (currently same as English) in all locales" >> comment.md + fi if [ "$ZOMBIES" -gt 0 ]; then echo "- Remove unused translation keys from locale files" >> comment.md fi diff --git a/public/changelog.html b/public/changelog.html index 092d4fe..edc5373 100644 --- a/public/changelog.html +++ b/public/changelog.html @@ -118,6 +118,7 @@

W
View Manager Releases @@ -125,6 +126,7 @@

W View Patches Releases @@ -177,10 +179,10 @@

Product

Community

- GitHub - X (Twitter) - Reddit - Crowdin + GitHub + X (Twitter) + Reddit + Crowdin

Language

diff --git a/public/donate.html b/public/donate.html index c0c0c8b..9c35ec4 100644 --- a/public/donate.html +++ b/public/donate.html @@ -294,10 +294,10 @@

Product

Community

- GitHub - X (Twitter) - Reddit - Crowdin + GitHub + X (Twitter) + Reddit + Crowdin

Language

diff --git a/public/index.html b/public/index.html index 9bbbe75..8972572 100644 --- a/public/index.html +++ b/public/index.html @@ -481,28 +481,28 @@

Join the Community

Follow us, report issues, and help make Morphe better

- +
GitHub

GitHub

Browse the source code, report bugs, and contribute to Morphe development.

 - +
X

X (Twitter)

Stay up to date with the latest news, releases, and announcements.

 - +
Reddit

Reddit

Join discussions, share tips, and connect with other Morphe users.

 - +
Crowdin
@@ -555,10 +555,10 @@

Product

Community

- GitHub - X (Twitter) - Reddit - Crowdin + GitHub + X (Twitter) + Reddit + Crowdin

Language

diff --git a/public/microg.html b/public/microg.html index 796975e..e036d34 100644 --- a/public/microg.html +++ b/public/microg.html @@ -177,10 +177,10 @@

Product

Community

- GitHub - X (Twitter) - Reddit - Crowdin + GitHub + X (Twitter) + Reddit + Crowdin

Language

diff --git a/public/translate.html b/public/translate.html index 5f9d9ef..3f272c4 100644 --- a/public/translate.html +++ b/public/translate.html @@ -227,10 +227,10 @@

Product

Community

- GitHub - X (Twitter) - Reddit - Crowdin + GitHub + X (Twitter) + Reddit + Crowdin

Language

diff --git a/scripts/check-translations.js b/scripts/check-translations.js index 68792a3..a81e663 100644 --- a/scripts/check-translations.js +++ b/scripts/check-translations.js @@ -24,6 +24,13 @@ const SKIP_KEYS = new Set([ 'hero.title-highlight-youtube', 'hero.title-highlight-ytmusic', 'hero.title-highlight-reddit', + 'app-features.tab-youtube', // product name + 'app-features.tab-ytmusic', // product name + 'app-features.tab-reddit', // product name + 'app-features.sponsorblock', // brand name + 'nav.faq', // universal abbreviation + 'changelog.filter-manager', // app name + 'changelog.filter-patches', // technical term ]); /** @@ -99,7 +106,9 @@ function checkCompleteness(locales) { const localeKeys = getAllKeys(locales[locale]).filter(key => !key.startsWith('testimonials.')); const missing = baseKeys.filter(key => !localeKeys.includes(key)); + const missingKeys = new Set(missing); const untranslated = baseKeys.filter(key => { + if (missingKeys.has(key)) return false; if (SKIP_KEYS.has(key)) return false; const baseValue = getValue(locales[BASE_LOCALE], key); const localeValue = getValue(locales[locale], key); @@ -107,8 +116,8 @@ function checkCompleteness(locales) { }); const total = baseKeys.length; - const translated = total - missing.length; - const percentage = Math.round((translated / total) * 100); + const translated = total - missing.length - untranslated.length; + const percentage = total > 0 ? Math.round((translated / total) * 100) : 100; results[locale] = { total, @@ -178,6 +187,11 @@ function generateReport(locales) { } else if (data.missingKeys.length > 10) { console.log(` Missing: ${data.missingKeys.slice(0, 5).join(', ')} ... and ${data.missingKeys.length - 5} more`); } + if (data.untranslatedKeys.length > 0 && data.untranslatedKeys.length <= 10) { + console.log(` Untranslated: ${data.untranslatedKeys.join(', ')}`); + } else if (data.untranslatedKeys.length > 10) { + console.log(` Untranslated: ${data.untranslatedKeys.slice(0, 5).join(', ')} ... and ${data.untranslatedKeys.length - 5} more`); + } console.log(); });