Skip to content

bug: patch button text nearly unreadable with certain custom accent colors when new updates are available #550

@neon16bit

Description

@neon16bit

Bug description

When using a light accent color with dark mode, the patch text is almost invisible. Similarly
dark accent color + light mode has readability issue for patch update button text

Dark + light color Light + dark color
Image Image

PrimaryActionButton hardcodes onSurface as the text color. Because the button uses a semi transparent accent over primaryContainer the onSurface text loses contrast whenever custom accents change the brightness of background.

I have a fix ready using CompositionLocalProvider and LocalContentColor without changing anything else

Version of Morphe (Manager) and the app you are patching

1.17.1

Morphe logs

theme issue

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The bug only affects using Morphe (Manager)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions