Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly need to StopEngine the FAudio engine before Releasing it #9

Open
kg opened this issue Dec 26, 2024 · 0 comments
Open

Possibly need to StopEngine the FAudio engine before Releasing it #9

kg opened this issue Dec 26, 2024 · 0 comments

Comments

@kg
Copy link

kg commented Dec 26, 2024

I'm locally using a modified version of Moonworks' Audio codebase and I get crashes at exit sometimes after Releasing the FAudio device. This seems to go away if I call StopEngine on the device before releasing it. When I test with breakpoints inside of a FAPO filter in one of my effect chains, it seems like the mixer (and thus callbacks) keep running even after you Release an FAudio device, so it's not safe to i.e. destroy streaming ogg buffers or things like that which the mixer might still be touching.

This may be specific to SDL3? The crashes happen inside of SDL3's mixer thread when it's calling into FAudio.

So my suggestion would be for Moonworks to call StopEngine before calling Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant