Skip to content

Commit fc15dda

Browse files
committed
Increase log severity for mixing Atomic and Decomposed behavior definitions
1 parent e40711a commit fc15dda

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

languages/basis/main/java/arcbasis/_cocos/AtomicNoConnector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ public void check(@NotNull ASTArcComponentType node) {
2222
if (!node.getSymbol().isAtomic()) return;
2323

2424
for (ASTArcElement e : node.getBody().getArcElementList()) {
25-
2625
if (e instanceof ASTConnector) {
27-
Log.warn(ArcError.CONNECTORS_IN_ATOMIC.toString(), e.get_SourcePositionStart(), e.get_SourcePositionEnd());
26+
Log.error(ArcError.CONNECTORS_IN_ATOMIC.toString(), e.get_SourcePositionStart(), e.get_SourcePositionEnd());
2827
}
2928
}
3029
}

languages/basis/main/java/arcbasis/_cocos/BehaviorInDecomposed.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public void check(@NotNull ASTArcComponentType node) {
1919
Preconditions.checkArgument(node.isPresentSymbol());
2020

2121
if (node.getSymbol().isDecomposed() && node.getBehavior().isPresent()) {
22-
Log.warn(
22+
Log.error(
2323
ArcError.DECOMPOSED_COMPONENT_WITH_BEHAVIOR.toString(),
2424
node.getBehavior().get().get_SourcePositionStart(),
2525
node.getBehavior().get().get_SourcePositionEnd()

languages/features/main/java/variablearc/_cocos/AtomicNoConnector4Family.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public void check(@NotNull ASTArcComponentType node) {
111111
Model model = ExpressionSolverService.getModel();
112112
for (Map.Entry<ASTConnector, BoolExpr> connector : connectorConditions.entrySet()) {
113113
if (evaluateCondition(model, connector.getValue())) {
114-
Log.warn(ArcError.CONNECTORS_IN_ATOMIC.toString(), connector.getKey().get_SourcePositionStart(), connector.getKey().get_SourcePositionEnd());
114+
Log.error(ArcError.CONNECTORS_IN_ATOMIC.toString(), connector.getKey().get_SourcePositionStart(), connector.getKey().get_SourcePositionEnd());
115115
}
116116
}
117117
}

0 commit comments

Comments
 (0)